GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update eslint-plugin-jsdoc by richardlau · Pull Request #48393 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Jun 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Run a subset of tools/dep_updaters/update-eslint.sh to update eslint-plugin-jsdoc to get rid of a spurious ENOENT error when running the linter.

Fixes: #48374

Ran this subset to update -- the script as a whole will exit early because eslint itself hasn't been updated:

node/tools/dep_updaters/update-eslint.sh

Lines 52 to 71 in f2670a6

(
cd node_modules/eslint
"$NODE" "$NPM" install \
--ignore-scripts \
--install-links=false \
--no-bin-links \
--no-save \
--omit=dev \
--omit=peer \
eslint-plugin-jsdoc \
eslint-plugin-markdown \
@babel/core \
@babel/eslint-parser \
@babel/plugin-syntax-import-assertions
)
# Use dmn to remove some unneeded files.
"$NODE" "$NPM" exec [email protected] --yes -- dmn -f clean
# TODO: Get this into dmn.
find node_modules -name .package-lock.json -exec rm {} \;
find node_modules -name 'README*' -exec rm {} \;

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau
tools: update eslint-plugin-jsdoc
b089ef2 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 8, 2023
@richardlau richardlau mentioned this pull request Jun 8, 2023
ENOENT running JS linter #48374
Closed
debadree25
debadree25 approved these changes Jun 8, 2023
View reviewed changes
lpinca
lpinca approved these changes Jun 8, 2023
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 8, 2023
VoltrexKeyva
VoltrexKeyva approved these changes Jun 8, 2023
View reviewed changes
aduh95
aduh95 approved these changes Jun 8, 2023
View reviewed changes
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 8, 2023
@github-actions

github-actions Bot commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Jun 9, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit da1c9e3 into nodejs:main Jun 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in da1c9e3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau
richardlau deleted the eslint branch June 9, 2023 07:38
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@richardlau @RafaelGSS
tools: update eslint-plugin-jsdoc
8009e2c 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.

PR-URL: #48393
Fixes: #48374
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: update eslint-plugin-jsdoc
0ae0f5b 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.

PR-URL: nodejs#48393
Fixes: nodejs#48374
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: update eslint-plugin-jsdoc
121d470 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.

PR-URL: nodejs#48393
Fixes: nodejs#48374
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@richardlau @ruyadorno
tools: update eslint-plugin-jsdoc
e278634 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.

PR-URL: #48393
Fixes: #48374
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@richardlau @ruyadorno
tools: update eslint-plugin-jsdoc
590a072 
Run a subset of `tools/dep_updaters/update-eslint.sh` to update
`eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
running the linter.

PR-URL: #48393
Fixes: #48374
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@debadree25 debadree25 debadree25 approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENOENT running JS linter

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@richardlau @nodejs-github-bot @lpinca @MoLow @aduh95 @debadree25 @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.