GeezerVison

cc @nodejs/whatwg-stream

Also, would this need node tests too? or WPTs are enough?

CI: https://ci.nodejs.org/job/node-test-pull-request/52169/

We should short circuit if we get a Node stream and use toWeb machinary if the spec allows

where to check for this? should make a issue on the spec repo? maybe @MattiasBuelens can help?

have addressed all the comments and will wait for some time if we would like to add .toWeb functionality like @benjamingr suggested

CI: https://ci.nodejs.org/job/node-test-pull-request/52185/

We should short circuit if we get a Node stream and use toWeb machinary if the spec allows

where to check for this? should make a issue on the spec repo? maybe @MattiasBuelens can help?

I would recommend something like:

// at the top-level
// ideally, this is exported by `lib/internal/streams/readable.js`
const originalReadableAsyncIterator = Readable.prototype[Symbol.asyncIterator];

// in readableStreamFromIterable
if (iterable instanceof Readable && iterable[Symbol.asyncIterator] === originalReadableAsyncIterator) {
 return Readable.toWeb(iterable);
}

This way, you can be certain that you're dealing with an unmodified Readable, and that there will be no behavioral differences compared to "going the long way" using Readable's async iterator.

I also suggest you write additional tests with polluted Readable instances, or with a polluted Readable.prototype. 😉

Hey one thing is it ok to export things from lib/internal/streams/readable.js something like originalReadableAsyncIterator as suggested? i know there is little bit restrictions in what we can export import in around the readable node stream part since its used in readablestream @benjamingr @mcollina

CI: https://ci.nodejs.org/job/node-test-pull-request/52751/

CI: https://ci.nodejs.org/job/node-test-pull-request/52752/

CI: https://ci.nodejs.org/job/node-test-pull-request/52753/

Hello everyone! I have reverted the change of toWeb for now (I shall do it in a follow up, since i was getting confused 😅) PTAL it seems ready to land!

Landed in b361ad7