GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update create-or-update-pull-request-action by richardlau · Pull Request #48398 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Jun 8, 2023

Copy link
Copy Markdown
Member

Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)

The workflow is currently failing: https://github.com/nodejs/node/actions/runs/5215729249/jobs/9413680952

Run gr2m/create-or-update-pull-request-action@df20b2c073090271599a08c55ae26e0c3522b329
Error: File not found: '/home/runner/work/_actions/gr2m/create-or-update-pull-request-action/df20b2c073090271599a08c55ae26e0c3522b329/dist/index.js'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau
tools: update create-or-update-pull-request-action
92a932a 
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 8, 2023
@richardlau

richardlau commented Jun 8, 2023

Copy link
Copy Markdown
Member Author

Workflow run with this PR: https://github.com/nodejs/node/actions/runs/5216284702/jobs/9414851477
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Jun 8, 2023
View reviewed changes

@marco-ippolito marco-ippolito left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau richardlau mentioned this pull request Jun 8, 2023
deps: update OpenSSL to 3.0.9-quic1 #48399
Closed
@richardlau

richardlau commented Jun 8, 2023

Copy link
Copy Markdown
Member Author

Workflow run with this PR: https://github.com/nodejs/node/actions/runs/5216284702/jobs/9414851477

This workflow run opened #48399 which looks correct, except because I ran the workflow from the branch from this PR it included the commit from this PR in #48399. I'll close off #48399 and we can rerun the fixed workflow from the main branch once this PR lands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Jun 9, 2023
View reviewed changes
@bnoordhuis bnoordhuis added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 9, 2023
@github-actions

github-actions Bot commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @bnoordhuis. Please 👍 to approve.
marco-ippolito and Mesteery reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mesteery
Mesteery approved these changes Jun 9, 2023
View reviewed changes
tniessen
tniessen approved these changes Jun 9, 2023
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6a3403c into main Jun 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6a3403c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the update-openssl-workflow branch June 9, 2023 11:54
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@richardlau @RafaelGSS
tools: update create-or-update-pull-request-action
a2e107d 
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: update create-or-update-pull-request-action
447cba3 
Use the same commit SHA for this action as used in our other workflows.

Refs: nodejs#46169
Refs: nodejs#45022 (comment)
PR-URL: nodejs#48398
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: update create-or-update-pull-request-action
df0ebba 
Use the same commit SHA for this action as used in our other workflows.

Refs: nodejs#46169
Refs: nodejs#45022 (comment)
PR-URL: nodejs#48398
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@richardlau @ruyadorno
tools: update create-or-update-pull-request-action
f9f2059 
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@richardlau @ruyadorno
tools: update create-or-update-pull-request-action
01bc10d 
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@tniessen tniessen tniessen approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@richardlau @nodejs-github-bot @bnoordhuis @tniessen @marco-ippolito @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.