GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: revise `error.md` introduction by aduh95 · Pull Request #48423 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

It was brought to my attention in #48357 (comment) that the introduction of error.md is quite outdated (no mention of promises, mentions node:domain without any deprecation notice).
The Error-first callbacks section in particular doesn't bring much value IMO (I think there are better resources to learn about callbacks elsewhere, and folks who don't already know what a callback is should probably not use them at this point), and contains some confusing wording (e.g. try..catch can be used to handle asynchronous errors using await, that section says otherwise). I'm removing this section in this PR, let me know if you think we should try to keep it and reword it instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
doc: revise error.md introduction
20b00d1
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core. labels Jun 11, 2023
lpinca
lpinca approved these changes Jun 14, 2023
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 14, 2023
Mesteery
Mesteery approved these changes Jun 15, 2023
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 64255b1 into nodejs:main Jun 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in 64255b1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the error-intro-update branch June 15, 2023 23:35
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@aduh95 @RafaelGSS
doc: revise error.md introduction
38bf290 
PR-URL: #48423
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
doc: revise error.md introduction
d9b42fd 
PR-URL: nodejs#48423
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
doc: revise error.md introduction
f0a2977 
PR-URL: nodejs#48423
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
@aduh95 @ruyadorno
doc: revise error.md introduction
ebe5416 
PR-URL: #48423
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@aduh95 @ruyadorno
doc: revise error.md introduction
3cf3fb9 
PR-URL: #48423
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @lpinca @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.