GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: fix premature pipeline end by ronag · Pull Request #48435 · nodejs/node

Conversation

@ronag

@ronag ronag commented Jun 12, 2023

Copy link
Copy Markdown
Member

Fixes: #48406

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ronag ronag added the stream Issues and PRs related to Node.js streams. label Jun 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 12, 2023
@ronag
ronag force-pushed the issue-48406 branch from b208392 to 41772d7 Compare June 12, 2023 13:17
mcollina
mcollina approved these changes Jun 12, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
marco-ippolito
marco-ippolito approved these changes Jun 12, 2023
View reviewed changes
@ronag
stream: fix premature pipeline end
ab1b4df 
Fixes: nodejs#48406
@ronag
ronag force-pushed the issue-48406 branch from 41772d7 to ab1b4df Compare June 12, 2023 15:57
debadree25
debadree25 approved these changes Jun 12, 2023
View reviewed changes
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 12, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52226/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52228/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52230/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jun 12, 2023
View reviewed changes
lpinca
lpinca approved these changes Jun 12, 2023
View reviewed changes
Comment thread test/parallel/test-stream-pipeline.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 13, 2023
CI Reliability 2023-06-13 nodejs/reliability#592
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52233/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented Jun 13, 2023

Copy link
Copy Markdown
Member

@nodejs/build it seems we can't build on ARM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jun 13, 2023

Copy link
Copy Markdown
Member

Can you try with a full run instead of a rebuild?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52235/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 14, 2023
CI Reliability 2023-06-14 nodejs/reliability#593
Open
CI Reliability 2023-06-15 nodejs/reliability#594
Open
@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48435
✔  Done loading data for nodejs/node/pull/48435
----------------------------------- PR info ------------------------------------
Title      stream: fix premature pipeline end (#48435)
Author     Robert Nagy  (@ronag)
Branch     ronag:issue-48406 -> nodejs:main
Labels     stream, author ready, needs-ci
Commits    1
 - stream: fix premature pipeline end
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/48435
Fixes: https://github.com/nodejs/node/issues/48406
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48435
Fixes: https://github.com/nodejs/node/issues/48406
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 12 Jun 2023 13:17:11 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48435#pullrequestreview-1474986414
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475174694
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475278074
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475471197
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-06-13T09:28:07Z: https://ci.nodejs.org/job/node-test-pull-request/52235/
- Querying data for job/node-test-pull-request/52235/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5277325882
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freeatnet freeatnet mentioned this pull request Jun 15, 2023
hardhat compile randomly and quietly stops before compiling contracts NomicFoundation/hardhat#3877
Closed
@debadree25 debadree25 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Jun 20, 2023
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52332/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 22, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 23, 2023
CI Reliability 2023-06-23 nodejs/reliability#596
Open
30 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52402/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 24, 2023
CI Reliability 2023-06-24 nodejs/reliability#597
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52415/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cebbc57 into nodejs:main Jun 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in cebbc57
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 25, 2023
CI Reliability 2023-06-25 nodejs/reliability#598
Open
CI Reliability 2023-06-26 nodejs/reliability#599
Open
CI Reliability 2023-06-27 nodejs/reliability#600
Open
@mcollina mcollina mentioned this pull request Jun 29, 2023
Cannot reliably use stream's pipeline function with an undici response's body in node v18.16.0 nodejs/undici#2173
Closed
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@ronag @RafaelGSS
stream: fix premature pipeline end
84d0eb7 
Fixes: #48406
PR-URL: #48435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ronag @Ceres6
stream: fix premature pipeline end
088d3a4 
Fixes: nodejs#48406
PR-URL: nodejs#48435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ronag @Ceres6
stream: fix premature pipeline end
21d60b3 
Fixes: nodejs#48406
PR-URL: nodejs#48435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@ronag @ruyadorno
stream: fix premature pipeline end
a72af53 
Fixes: #48406
PR-URL: #48435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@ronag @ruyadorno
stream: fix premature pipeline end
786fbdb 
Fixes: #48406
PR-URL: #48435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@simatec simatec mentioned this pull request Oct 5, 2023
tar has problems in a CIFS mount path with node 20 and node 18.18.0 isaacs/node-tar#394
Closed
@teogeb teogeb mentioned this pull request Jan 16, 2025
test: [ETH-811] Fix crashing Solidity compiler download streamr-dev/network-contracts#951
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream.pipeline abruptly kill the node process

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ronag @nodejs-github-bot @mcollina @targos @benjamingr @lpinca @debadree25 @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.