GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — net: improve network family autoselection handle handling by ShogunPanda · Pull Request #48464 · nodejs/node

Conversation

@ShogunPanda

@ShogunPanda ShogunPanda commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

This PR fixes network family autoselections in three area:

  1. Moves handle swapping before trying a new connection, as suggested in npm ERR! Exit handler never called! npm/cli#6409 (comment)
  2. Avoids spawning two different connection attempts, which could happen if a TLSSocket with a manually set backing Socket was used. See: PSA: If you're on node 20.0.0 and above, and want to use this library with client.configuration.connection.secure === true, use the argument --no-network-family-autoselection KararTY/dank-twitch-irc#13 (comment)
  3. Correctly handles AbortSignal when using network family auto selection.

Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644

CC: @tniessen @silverwind

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and brian6932 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 15, 2023
This was referenced Jun 15, 2023
Revert "net: enable autoSelectFamily by default" #48403
Closed
SIGNAL USERS READ THIS FIRST: code: 'ERR_INTERNAL_ASSERTION' in internalConnectMultiple #47644
Closed
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52262/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52263/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Jun 16, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShogunPanda ShogunPanda mentioned this pull request Jun 19, 2023
test-net-bytes-per-incoming-chunk-overhead failing on Fedora 38 #48490
Closed
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52340/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 24, 2023
View reviewed changes
@ShogunPanda

ShogunPanda commented Jun 24, 2023

Copy link
Copy Markdown
Contributor Author

I'll check the failing test locally this evening and then I'll update and finally merge this.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShogunPanda
net: improve network family autoselection handle handling
16ab933
@ShogunPanda
ShogunPanda force-pushed the network-selection-handle-improvements branch from 5388aa7 to 16ab933 Compare June 26, 2023 07:33
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 26, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52487/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52499/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 27, 2023
CI Reliability 2023-06-27 nodejs/reliability#600
Open
24 tasks
marco-ippolito
marco-ippolito approved these changes Jun 27, 2023
View reviewed changes
@ShogunPanda ShogunPanda added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fddd3ff into nodejs:main Jun 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in fddd3ff
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShogunPanda
ShogunPanda deleted the network-selection-handle-improvements branch June 27, 2023 11:17
This was referenced Jun 28, 2023
CI Reliability 2023-06-28 nodejs/reliability#601
Open
CI Reliability 2023-06-29 nodejs/reliability#602
Open
CI Reliability 2023-06-30 nodejs/reliability#603
Open
CI Reliability 2023-07-01 nodejs/reliability#604
Open
@bnoordhuis bnoordhuis mentioned this pull request Jul 1, 2023
fatal error: all goroutines are asleep - deadlock! #48623
Closed
This was referenced Jul 2, 2023
CI Reliability 2023-07-02 nodejs/reliability#605
Open
CI Reliability 2023-07-03 nodejs/reliability#606
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@ShogunPanda @RafaelGSS
net: improve network family autoselection handle handling
2c36397 
PR-URL: #48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
hail2u added a commit to hail2u/hail2u.net that referenced this pull request Jul 16, 2023
@hail2u
Bookmark nodejs/node#48464
8625e85
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: improve network family autoselection handle handling
9ffc304 
PR-URL: nodejs#48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: nodejs#47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: improve network family autoselection handle handling
f251e28 
PR-URL: nodejs#48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: nodejs#47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPanda ShogunPanda mentioned this pull request Aug 17, 2023
Backport 48969 to v18.x staging v2 #49183
Closed
@ruyadorno

ruyadorno commented Sep 10, 2023

Copy link
Copy Markdown
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-requested-v18.x label Sep 10, 2023
@lukekarrys lukekarrys mentioned this pull request Sep 11, 2023
[BUG] MaxListenersExceededWarning: Possible EventEmitter memory leak detected. (v10) npm/cli#6763
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PSA: If you're on node 20.0.0 and above, and want to use this library with client.configuration.connection.secure === true, use the argument --no-network-family-autoselection npm ERR! Exit handler never called! SIGNAL USERS READ THIS FIRST: code: 'ERR_INTERNAL_ASSERTION' in internalConnectMultiple

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ShogunPanda @nodejs-github-bot @ruyadorno @mcollina @benjamingr @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.