GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update lint-md-dependencies to [email protected] [email protected] [email protected] by nodejs-github-bot · Pull Request #48486 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Jun 18, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of lint-md-dependencies to [email protected] [email protected] [email protected].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 18, 2023
@Trott Trott added the needs-ci PRs that need a full CI run. label Jun 18, 2023
@Trott
Trott force-pushed the actions/tools-update-lint-md-dependencies branch from fd8061a to b3d0752 Compare June 18, 2023 01:36
Trott
Trott approved these changes Jun 18, 2023
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added needs-ci because lint-md.mjs is changed and in the past that has broken running on some of the Jenkins builds that set configuration flags.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
MoLow
MoLow approved these changes Jun 18, 2023
View reviewed changes
lpinca
lpinca approved these changes Jun 18, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 18, 2023
VoltrexKeyva
VoltrexKeyva approved these changes Jun 19, 2023
View reviewed changes
Mesteery
Mesteery approved these changes Jun 19, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52292/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
@nodejs-github-bot @Trott
tools: update lint-md-dependencies
a18552d 
Updates: [email protected] [email protected] [email protected]
@Trott
Trott force-pushed the actions/tools-update-lint-md-dependencies branch from b3d0752 to a18552d Compare June 21, 2023 15:36
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52345/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 22, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/48486
✔  Done loading data for nodejs/node/pull/48486
----------------------------------- PR info ------------------------------------
Title      tools: update lint-md-dependencies to [email protected] [email protected] [email protected] (#48486)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-lint-md-dependencies -> nodejs:main
Labels     tools, author ready, needs-ci
Commits    1
 - tools: update lint-md-dependencies
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/48486
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Mestery 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48486
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Mestery 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: update lint-md-dependencies
   ℹ  This PR was created on Sun, 18 Jun 2023 00:29:27 GMT
   ✔  Approvals: 5
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48486#pullrequestreview-1484946023
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48486#pullrequestreview-1484978691
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48486#pullrequestreview-1484979498
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48486#pullrequestreview-1486321900
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48486#pullrequestreview-1487021697
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-22T15:33:43Z: https://ci.nodejs.org/job/node-test-pull-request/52345/
- Querying data for job/node-test-pull-request/52345/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5347934682
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jun 22, 2023
View reviewed changes
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b352e0c into main Jun 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in b352e0c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-lint-md-dependencies branch June 22, 2023 16:34
This was referenced Jun 23, 2023
CI Reliability 2023-06-23 nodejs/reliability#596
Open
CI Reliability 2023-06-24 nodejs/reliability#597
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@nodejs-github-bot @RafaelGSS
tools: update lint-md-dependencies
10bd5f4 
Updates: [email protected] [email protected] [email protected]
PR-URL: #48486
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
tools: update lint-md-dependencies
0caddc5 
Updates: [email protected] [email protected] [email protected]
PR-URL: nodejs#48486
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
tools: update lint-md-dependencies
9214d12 
Updates: [email protected] [email protected] [email protected]
PR-URL: nodejs#48486
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@nodejs-github-bot @ruyadorno
tools: update lint-md-dependencies
b673d4a 
Updates: [email protected] [email protected] [email protected]
PR-URL: #48486
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@nodejs-github-bot @ruyadorno
tools: update lint-md-dependencies
e168eab 
Updates: [email protected] [email protected] [email protected]
PR-URL: #48486
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
+2 more reviewers
@Mesteery Mesteery Mesteery approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nodejs-github-bot @Trott @lpinca @MoLow @Mesteery @VoltrexKeyva @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.