GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: revert IS_RELEASE by RafaelGSS · Pull Request #48505 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Jun 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I messed up somehow when performing the last 3 releases

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@RafaelGSS RafaelGSS added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 20, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 20, 2023
@github-actions

github-actions Bot commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

juanarbol, richardlau, benjamingr, MoLow, ruyadorno, bricss, marco-ippolito, anonrig, targos, and JakobJingleheimer reacted with thumbs up emoji
All reactions
  • 👍 10 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS removed the needs-ci PRs that need a full CI run. label Jun 20, 2023
juanarbol
juanarbol approved these changes Jun 20, 2023
View reviewed changes
richardlau
richardlau approved these changes Jun 20, 2023
View reviewed changes
benjamingr
benjamingr approved these changes Jun 20, 2023
View reviewed changes
MoLow
MoLow approved these changes Jun 20, 2023
View reviewed changes
ruyadorno
ruyadorno approved these changes Jun 20, 2023
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 20, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52299/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig
anonrig approved these changes Jun 21, 2023
View reviewed changes
@RafaelGSS

RafaelGSS commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

lint-py seems to be failing in other PRs (see #48504)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

I think it's ok to ignore it and land manually?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Jun 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

lint-py seems to be failing in other PRs (see #48504)

The culprit for that problem appears to be 4c22414. (Although the linter presumably passed when that landed. Maybe a recent change in ruff or something like that?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Jun 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yeah, looks like a new version of ruff was released today! 😱 We should probably pin the version in Makefile and vcbuild.bat, and update manually. (EDIT: It doesn't exist in vcbuild.bat so I pinned it in Makefile only.)

ruyadorno reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS and others added 2 commits June 20, 2023 20:46
@RafaelGSS @Trott
src: revert IS_RELEASE
275e512
@Trott
tools: pin ruff version number
e0ec294
New versions have new rules and end up breaking builds unexpectedly.
@Trott
Trott force-pushed the fix-is-release-sec branch from 117cf89 to e0ec294 Compare June 21, 2023 03:46
@Trott Trott added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52302/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Jun 21, 2023
View reviewed changes
GeoffreyBooth
GeoffreyBooth approved these changes Jun 21, 2023
View reviewed changes
lpinca
lpinca approved these changes Jun 21, 2023
View reviewed changes
targos pushed a commit that referenced this pull request Jun 21, 2023
@RafaelGSS @targos
src: revert IS_RELEASE
44fd53a
PR-URL: #48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jun 21, 2023
@Trott @targos
tools: pin ruff version number
198affc
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos

targos commented Jun 21, 2023

Copy link
Copy Markdown
Member

Landed in 49951ec...198affc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos closed this Jun 21, 2023
@github-actions github-actions Bot mentioned this pull request Jun 23, 2023
CI Reliability 2023-06-23 nodejs/reliability#596
Open
30 tasks
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
@RafaelGSS
src: revert IS_RELEASE
5bc13a4
PR-URL: #48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@Trott @RafaelGSS
tools: pin ruff version number
52de27b
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 13, 2023
@Trott @MoLow
tools: pin ruff version number
438accd
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MoLow MoLow mentioned this pull request Jul 13, 2023
[v18.x]: fix py-lint #48753
Closed
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@Trott @danielleadams
tools: pin ruff version number
7786d7c
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Backport-PR-URL: #48753
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 17, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE
5e89fa9
PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: pin ruff version number
14e9b17
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE
9d3956f
PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: pin ruff version number
94cc703
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@RafaelGSS @nodejs-github-bot @Trott @targos @ruyadorno @GeoffreyBooth @benjamingr @lpinca @anonrig @richardlau @MoLow @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.