GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update googletest to ec4fed9 by nodejs-github-bot · Pull Request #48538 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Jun 24, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of googletest to ec4fed9.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
deps: update googletest to ec4fed9
521ff5e
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. test Issues and PRs related to Node.js core tests and test infrastructure. needs-ci PRs that need a full CI run. labels Jun 24, 2023
@tniessen tniessen mentioned this pull request Jun 24, 2023
deps: update googletest to 9b12f74 #47622
Closed
tniessen
tniessen approved these changes Jun 24, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. The upstream commit google/googletest@ec4fed9 landed more than 48 hours before this PR was opened, as intended.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52428/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 24, 2023
lpinca
lpinca approved these changes Jun 24, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Jun 24, 2023
View reviewed changes
aduh95
aduh95 reviewed Jun 24, 2023
View reviewed changes
Comment thread doc/contributing/maintaining/maintaining-dependencies.md
by Node.js by default.

### googletest
### googletest ec4fed9

@aduh95 aduh95 Jun 24, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird, it's the only one in the list that uses a hash as version number..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5e5a01b into main Jun 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 5e5a01b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-googletest branch June 29, 2023 04:57
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@nodejs-github-bot @RafaelGSS
deps: update googletest to ec4fed9
ed1d047 
PR-URL: #48538
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
deps: update googletest to ec4fed9
4c74465 
PR-URL: nodejs#48538
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
deps: update googletest to ec4fed9
65c0a29 
PR-URL: nodejs#48538
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@nodejs-github-bot @ruyadorno
deps: update googletest to ec4fed9
8843274 
PR-URL: #48538
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@nodejs-github-bot @ruyadorno
deps: update googletest to ec4fed9
56249b0 
PR-URL: #48538
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nodejs-github-bot @lpinca @tniessen @aduh95 @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.