GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http, https, http2: Server add `Symbol.asyncDispose` by atlowChemi · Pull Request #48548 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented Jun 25, 2023

Copy link
Copy Markdown
Member

Refs: #48518, https://github.com/tc39/proposal-explicit-resource-management

CC @benjamingr @MoLow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jun 25, 2023
@atlowChemi
atlowChemi requested review from MoLow and benjamingr June 25, 2023 17:54
@atlowChemi
atlowChemi force-pushed the http-server-async-dispose branch from 7fff95c to 6f92f87 Compare June 25, 2023 18:00
benjamingr
benjamingr reviewed Jun 25, 2023
View reviewed changes
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Jun 25, 2023
View reviewed changes
Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Jun 25, 2023
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good left some comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@atlowChemi
atlowChemi force-pushed the http-server-async-dispose branch from 6f92f87 to d293a6a Compare June 25, 2023 18:03
@atlowChemi
http: server add async dispose
81f630f
@atlowChemi
atlowChemi force-pushed the http-server-async-dispose branch from d293a6a to 81f630f Compare June 25, 2023 18:16
@atlowChemi atlowChemi changed the title http: Server add Symbol.asyncDispose http, http2: Server add Symbol.asyncDispose Jun 25, 2023
@atlowChemi atlowChemi added the http2 Issues and PRs related to the http2 subsystem. label Jun 25, 2023
atlowChemi added 2 commits June 25, 2023 23:27
@atlowChemi
http2: Server add asyncDispose
bb04854
@atlowChemi
https: Server add asyncDispose
7577fd8
@atlowChemi
atlowChemi requested a review from benjamingr June 25, 2023 20:30
@atlowChemi
atlowChemi force-pushed the http-server-async-dispose branch from bd52b5a to 7577fd8 Compare June 25, 2023 20:30
@atlowChemi atlowChemi added the https Issues and PRs related to the https subsystem. label Jun 25, 2023
@atlowChemi atlowChemi changed the title http, http2: Server add Symbol.asyncDispose http, https, http2: Server add Symbol.asyncDispose Jun 25, 2023
MoLow
MoLow approved these changes Jun 25, 2023
View reviewed changes
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52474/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 26, 2023
CI Reliability 2023-06-26 nodejs/reliability#599
Open
21 tasks
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 26, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52477/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52479/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShogunPanda
ShogunPanda approved these changes Jun 26, 2023
View reviewed changes

@ShogunPanda ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MoLow pushed a commit that referenced this pull request Jun 29, 2023
@atlowChemi @MoLow
http: server add async dispose
909b43f 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
MoLow pushed a commit that referenced this pull request Jun 29, 2023
@atlowChemi @MoLow
http2: server add asyncDispose
b7bfb17 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
MoLow pushed a commit that referenced this pull request Jun 29, 2023
@atlowChemi @MoLow
https: server add asyncDispose
e8810b9 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@atlowChemi
atlowChemi deleted the http-server-async-dispose branch June 29, 2023 08:55
This was referenced Jun 30, 2023
CI Reliability 2023-06-30 nodejs/reliability#603
Open
CI Reliability 2023-07-01 nodejs/reliability#604
Open
CI Reliability 2023-07-02 nodejs/reliability#605
Open
CI Reliability 2023-07-03 nodejs/reliability#606
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
http: server add async dispose
94ebb02 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
http2: server add asyncDispose
5378ad8 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
https: server add asyncDispose
97a58c5 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
@github-actions github-actions Bot mentioned this pull request Jul 4, 2023
CI Reliability 2023-07-04 nodejs/reliability#607
Open
22 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
http: server add async dispose
377a9f4 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
http2: server add asyncDispose
1aad923 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
https: server add asyncDispose
a9efe2e 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
http: server add async dispose
9df83ae 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
http2: server add asyncDispose
0af65d0 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
https: server add asyncDispose
6fcb5d2 
PR-URL: nodejs#48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
http: server add async dispose
3edeeac 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
http2: server add asyncDispose
3ecc607 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
https: server add asyncDispose
9e9b8a3 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
v18.18.0 proposal #49220
Merged
@ruyadorno

ruyadorno commented Sep 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR is not landing cleanly on v18.x-staging since #48383 had to be removed. It's going to be blocked pending the backport of that PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-blocked-v18.x label Sep 12, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
http: server add async dispose
fcd0424 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
http2: server add asyncDispose
7a00bda 
PR-URL: #48548
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@mcollina mcollina mcollina approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. http Issues and PRs related to the http subsystem. http2 Issues and PRs related to the http2 subsystem. https Issues and PRs related to the https subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@atlowChemi @nodejs-github-bot @MoLow @ruyadorno @mcollina @ShogunPanda @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.