GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: declare `path` on example of `async_hooks.executionAsyncId()` by deokjinkim · Pull Request #48556 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Example is not runnable because path is used, but it's not declared.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@deokjinkim
doc: declare path on example of async_hooks.executionAsyncId()
aae0908 
Example is not runnable because `path` is used, but it's not
declared.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Jun 26, 2023
deokjinkim
deokjinkim commented Jun 26, 2023
View reviewed changes
Comment thread doc/api/async_hooks.md
console.log(executionAsyncId()); // 1 - bootstrap
const path = '.';
fs.open(path, 'r', (err, fd) => {
console.log(executionAsyncId()); // 6 - open()

@deokjinkim deokjinkim Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, actual output of ESM is 11(not 6) on linux.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deokjinkim
deokjinkim marked this pull request as ready for review June 26, 2023 04:17
@deokjinkim
deokjinkim requested a review from guybedford July 5, 2023 13:15
lpinca
lpinca approved these changes Jul 18, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 77ea173 into nodejs:main Jul 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 77ea173
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@deokjinkim @Ceres6
doc: declare path on example of async_hooks.executionAsyncId()
2edbd67 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: nodejs#48556
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@deokjinkim @Ceres6
doc: declare path on example of async_hooks.executionAsyncId()
a17982d 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: nodejs#48556
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@deokjinkim @UlisesGascon
doc: declare path on example of async_hooks.executionAsyncId()
f224aeb 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: nodejs#48556
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@deokjinkim @RafaelGSS
doc: declare path on example of async_hooks.executionAsyncId()
388c7d9 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: #48556
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@deokjinkim @targos
doc: declare path on example of async_hooks.executionAsyncId()
629132d 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: #48556
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: declare path on example of
0650a56 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: nodejs/node#48556
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: declare path on example of
76c21fe 
Example is not runnable because `path` is used, but it's not
declared.

PR-URL: nodejs/node#48556
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@guybedford guybedford Awaiting requested review from guybedford

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@deokjinkim @nodejs-github-bot @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.