GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: null the joinDuplicateHeaders property on cleanup by lpinca · Pull Request #48608 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Jun 30, 2023

Copy link
Copy Markdown
Member

Null the joinDuplicateHeaders property when the parser is freed.

Refs: #45982

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@lpinca
http: null the joinDuplicateHeaders property on cleanup
03ad516 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: nodejs#45982
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jun 30, 2023
marco-ippolito
marco-ippolito approved these changes Jun 30, 2023
View reviewed changes

@marco-ippolito marco-ippolito left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca

lpinca commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

This deflakes the parallel/test-http-request-join-authorization-headers test. The problem was that a parser with the property set to true was picked up on the server. See https://ci.nodejs.org/job/node-test-pull-request/52475/

not ok 1251 parallel/test-http-request-join-authorization-headers
  ---
  duration_ms: 245.54800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    '1, 2' !== '1'
    
        at Server.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/parallel/test-http-request-join-authorization-headers.js:39:12)
        at Server.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/common/index.js:466:15)
        at Server.emit (node:events:512:28)
        at parserOnIncoming (node:_http_server:1125:12)
        at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '1, 2',
      expected: '1',
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0-pre
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2023
lpinca
lpinca commented Jun 30, 2023
View reviewed changes
Comment thread test/parallel/test-http-parser-memory-retention.js
server.listen(common.mustCall(() => {
const request = http.get({ port: server.address().port });
const request = http.get({
headers: { Connection: 'close' },

@lpinca lpinca Jun 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added only to speed up the test. There is no need to wait for the keep-alive timeout to expire.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52567/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Jun 30, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52568/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 30, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jul 1, 2023
CI Reliability 2023-07-01 nodejs/reliability#604
Open
30 tasks
KhafraDev
KhafraDev approved these changes Jul 1, 2023
View reviewed changes
This was referenced Jul 2, 2023
CI Reliability 2023-07-02 nodejs/reliability#605
Open
CI Reliability 2023-07-03 nodejs/reliability#606
Open
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 651c02c into nodejs:main Jul 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 651c02c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca
lpinca deleted the clean/http-parser branch July 3, 2023 06:22
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
http: null the joinDuplicateHeaders property on cleanup
7d8a0b6 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: #45982
PR-URL: #48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
This was referenced Jul 4, 2023
CI Reliability 2023-07-04 nodejs/reliability#607
Open
CI Reliability 2023-07-05 nodejs/reliability#608
Open
CI Reliability 2023-07-06 nodejs/reliability#609
Open
CI Reliability 2023-07-07 nodejs/reliability#610
Open
CI Reliability 2023-07-08 nodejs/reliability#611
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
http: null the joinDuplicateHeaders property on cleanup
baf8d33 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: nodejs#45982
PR-URL: nodejs#48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
http: null the joinDuplicateHeaders property on cleanup
ba1cf4b 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: nodejs#45982
PR-URL: nodejs#48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
http: null the joinDuplicateHeaders property on cleanup
27d6833 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: #45982
PR-URL: #48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
http: null the joinDuplicateHeaders property on cleanup
eb4550a 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: #45982
PR-URL: #48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@lpinca @ruyadorno
http: null the joinDuplicateHeaders property on cleanup
01746c7 
Null the `joinDuplicateHeaders` property when the parser is freed.

Refs: #45982
PR-URL: #48608
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@lpinca @nodejs-github-bot @mcollina @benjamingr @marco-ippolito @KhafraDev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.