GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: start connections checking interval on listen by ShogunPanda · Pull Request #48611 · nodejs/node

Conversation

@ShogunPanda

@ShogunPanda ShogunPanda commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

This PR fixes a memory leak by checking HTTP connections only if the server is listening.

Fixes: #48604.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jun 30, 2023
mcollina
mcollina approved these changes Jun 30, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52569/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito
marco-ippolito approved these changes Jun 30, 2023
View reviewed changes
mscdex
mscdex reviewed Jun 30, 2023
View reviewed changes
Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

mscdex
mscdex reviewed Jun 30, 2023
View reviewed changes
Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca reviewed Jun 30, 2023
View reviewed changes
Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread lib/_http_server.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jul 1, 2023
CI Reliability 2023-07-01 nodejs/reliability#604
Open
CI Reliability 2023-07-02 nodejs/reliability#605
Open
CI Reliability 2023-07-03 nodejs/reliability#606
Open
@ShogunPanda
ShogunPanda force-pushed the http-server-check-on-listening branch from 7b23c64 to 94b4764 Compare July 3, 2023 07:33
lpinca
lpinca reviewed Jul 3, 2023
View reviewed changes
Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ShogunPanda

ShogunPanda commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

@lpinca I reworked tests using Countdown. I noticed setInterval was unnecessary.
What about now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ShogunPanda
ShogunPanda force-pushed the http-server-check-on-listening branch from 3929991 to e86f329 Compare July 3, 2023 11:00
lpinca
lpinca reviewed Jul 3, 2023
View reviewed changes
Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-https-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-https-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ShogunPanda
ShogunPanda force-pushed the http-server-check-on-listening branch from e86f329 to bbf9f88 Compare July 3, 2023 14:00
lpinca
lpinca reviewed Jul 3, 2023
View reviewed changes
Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca reviewed Jul 3, 2023
View reviewed changes
Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-https-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca reviewed Jul 3, 2023
View reviewed changes
Comment thread test/parallel/test-http-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/parallel/test-https-server-connections-checking-leak.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Jul 4, 2023
CI Reliability 2023-07-04 nodejs/reliability#607
Open
22 tasks
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52589/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcollina mcollina mentioned this pull request Jul 4, 2023
v20.4.0 proposal #48643
Merged
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52591/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Jul 4, 2023
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Jul 24, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52920/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52921/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ShogunPanda ShogunPanda added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jul 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8490318 into nodejs:main Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8490318

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ShogunPanda
ShogunPanda deleted the http-server-check-on-listening branch July 24, 2023 21:26
This was referenced Jul 25, 2023
CI Reliability 2023-07-25 nodejs/reliability#623
Open
CI Reliability 2023-07-26 nodejs/reliability#624
Open
CI Reliability 2023-07-27 nodejs/reliability#625
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@ShogunPanda @lpinca @Ceres6
http: start connections checking interval on listen
1650c76
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
This was referenced Jul 28, 2023
CI Reliability 2023-07-28 nodejs/reliability#626
Open
CI Reliability 2023-07-29 nodejs/reliability#627
Open
CI Reliability 2023-07-30 nodejs/reliability#628
Open
CI Reliability 2023-07-31 nodejs/reliability#629
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @lpinca @Ceres6
http: start connections checking interval on listen
a47a904
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @lpinca @Ceres6
http: start connections checking interval on listen
cd76484
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@ShogunPanda @lpinca @UlisesGascon
http: start connections checking interval on listen
be547b3
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@ShogunPanda @lpinca @RafaelGSS
http: start connections checking interval on listen
222ce81
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: #48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@ShogunPanda @lpinca @RafaelGSS
http: start connections checking interval on listen
742597b
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: #48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@mcollina mcollina mentioned this pull request Sep 11, 2023
Tracking issue for Fastify regressions #49600
Closed
targos pushed a commit that referenced this pull request Nov 27, 2023
@ShogunPanda @lpinca @targos
http: start connections checking interval on listen
8874b2e
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: #48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher @lpinca
http: start connections checking interval on listen
b46a0f0
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher @lpinca
http: start connections checking interval on listen
1147592
Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#48611
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theanarkh theanarkh theanarkh left review comments
@mcollina mcollina mcollina approved these changes
@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http: memory leak if a server is not closed

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@ShogunPanda @nodejs-github-bot @StefanStojanovic @lpinca @mcollina @mscdex @theanarkh @RafaelGSS @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.