GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: add `__proto__` null by rluvaton · Pull Request #48663 · nodejs/node

Conversation

@rluvaton

@rluvaton rluvaton commented Jul 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

extracted from:

  • tools: add eslint rule for __proto__: null in object #48646

TODO:

  • Run CITGM
  • mark as a major change

reference: #48646 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 5, 2023
@anonrig anonrig added the needs-benchmark-ci PRs that need a benchmark CI run. label Jul 6, 2023
@aduh95

aduh95 commented Jul 9, 2023

Copy link
Copy Markdown
Contributor

anonrig added the needs-benchmark-ci PRs that need a benchmark CI run.

@anonrig we don't have benchmarks for the test runner – and I don't think we need it for this PR.

TODO:

  • Run CITGM
  • mark as a major change

IMHO that would be overkill for this PR:

  • I don't think we need it for node:test code: it's been designed to minimize the risk of user code influencing its results, so the changes in this PR should not be observable for users – and if they are, we would consider it a bug, so this would still be a patch rather than a breaking change.
  • I don't think we need it for code related to node --test, because no user code would be run in the process.
  • Also, because this code is relatively new, I think it's fair to assume no one is relying on mutating %Object.prototype% anyway.

That being said, if others think differently, I'm OK with taking the more prudent path.
benjamingr and atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jul 9, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52666/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton

rluvaton commented Jul 10, 2023

Copy link
Copy Markdown
Member Author

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

Sure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton

rluvaton commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

see #48646 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Jul 19, 2023
View reviewed changes
@rluvaton

rluvaton commented Jul 20, 2023

Copy link
Copy Markdown
Member Author

@aduh95 I've added the eslint rule...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Jul 21, 2023
View reviewed changes
Comment thread .eslintrc.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

There are a few tests that need fixing. Also can you please rebase on top of main? Merge commits tend to break our tooling.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton

rluvaton commented Jul 24, 2023

Copy link
Copy Markdown
Member Author

@aduh95 done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

@rluvaton thanks, but it seems the merge commit is still there, and there are a few unrelated commits that were added. Did you maybe rebase main on top of your branch, instead of rebasing your branch on top of main? Let me know if you'd prefer I take care of it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
rluvaton force-pushed the add-proto-null-to-test-runner branch from 1862cb6 to 32b3373 Compare July 24, 2023 08:40
@rluvaton

rluvaton commented Jul 24, 2023

Copy link
Copy Markdown
Member Author

thanks, but it seems the merge commit is still there, and there are a few unrelated commits that were added. Did you maybe rebase main on top of your branch, instead of rebasing your branch on top of main? Let me know if you'd prefer I take care of it.

it would be great, I'm having problem for some reason
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jul 24, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52915/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 25, 2023
CI Reliability 2023-07-25 nodejs/reliability#623
Open
CI Reliability 2023-07-26 nodejs/reliability#624
Open
CI Reliability 2023-07-27 nodejs/reliability#625
Open
CI Reliability 2023-07-28 nodejs/reliability#626
Open
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2023
@rluvaton

rluvaton commented Jul 28, 2023

Copy link
Copy Markdown
Member Author

@aduh95 done and fixed the original issue as well
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Jul 28, 2023
View reviewed changes
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52965/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton

rluvaton commented Jul 28, 2023

Copy link
Copy Markdown
Member Author

failed again on a different unreleated thing...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52970/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jul 29, 2023
CI Reliability 2023-07-29 nodejs/reliability#627
Open
23 tasks
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ee391f3 into nodejs:main Jul 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in ee391f3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 30, 2023
CI Reliability 2023-07-30 nodejs/reliability#628
Open
CI Reliability 2023-07-31 nodejs/reliability#629
Open
CI Reliability 2023-08-01 nodejs/reliability#630
Open
CI Reliability 2023-08-02 nodejs/reliability#631
Open
CI Reliability 2023-08-03 nodejs/reliability#632
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: add __proto__ null
c8c5ef9 
PR-URL: nodejs#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: add __proto__ null
fc67767 
PR-URL: nodejs#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@rluvaton @UlisesGascon
test_runner: add __proto__ null
3f9b679 
PR-URL: nodejs#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test_runner: add __proto__ null
c9ad263 
PR-URL: #48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test_runner: add __proto__ null
8a93829 
PR-URL: nodejs#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@rluvaton @RafaelGSS
test_runner: add __proto__ null
fa19b0e 
PR-URL: #48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@rluvaton @targos
test_runner: add __proto__ null
3a74316 
PR-URL: #48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add __proto__ null
8425cab 
PR-URL: nodejs/node#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add __proto__ null
a5b13c7 
PR-URL: nodejs/node#48663
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-benchmark-ci PRs that need a benchmark CI run. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@rluvaton @nodejs-github-bot @aduh95 @atlowChemi @benjamingr @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.