GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — permission: add debug log when inserting fs nodes by RafaelGSS · Pull Request #48677 · nodejs/node Conversation
Member
This will help when debugging issues in the filesystem Radix tree. Output example: $ NODE_DEBUG_NATIVE=PERMISSION_MODEL ./node --experimental-permission --allow-fs-read=/tmp/,/home/,/host -p '1 + 1' Inserting /tmp/* Prefix: Child(1): / Wildcard: /tmp/* End of tree - child(1) Inserting /home/* Prefix: Child(1): / Prefix: / Child(1): h Wildcard: home/* Child(2): t Wildcard: tmp/* End of tree - child(2) End of tree - child(1) Inserting /host Prefix: Child(1): / Prefix: / Child(1): h Prefix: ho Child(1): s Prefix: st End of tree: st Child(2): m Wildcard: me/* End of tree - child(2) Child(2): t Wildcard: tmp/* End of tree - child(2) End of tree - child(1) 2 (node:999070) ExperimentalWarning: Permission is an experimental feature (Use `node --trace-warnings ...` to show where the warning was created) cc: @nodejs/security-wg
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Signed-off-by: RafaelGSS <[email protected]>
ShogunPanda
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
juanarbol
pushed a commit
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
Merged
tniessen
added a commit
to tniessen/node
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677
nodejs-github-bot
pushed a commit
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48677 Reviewed-By: Paolo Insogna <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48677 Reviewed-By: Paolo Insogna <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
c++
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 4 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |