GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — tools: added support for notarytool for osx notarization by UlisesGascon · Pull Request #48701 · nodejs/node Conversation
|
|
We have a new job in the release CI to test this script: https://ci-release.nodejs.org/job/testing-new-osx-notarization-ojs+release/. Next steps:
Thanks for the great pairing session @mhdawson! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @UlisesGascon thanks for putting this together
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
To clarify for readers in terms of
It is really By November 1, 2023 we |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I think that this will make imposible to notarize releases with Based on xcodereleases Important: Node.js should/can be tested in macos 10.15, this only affect the release process |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: #48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
landed in e97d256 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Maybe someone with a mac can verify if the https://nodejs.org/download/nightly/v21.0.0-nightly202309295570c29780/node-v21.0.0-nightly202309295570c29780.pkg macOS build was notarized? We didn't get a "Your Mac software was successfully notarized." email from Apple for v21.0.0-nightly202309295570c29780 but maybe that's a change with the use of the new tool? FWIW https://ci-release.nodejs.org/job/iojs+release/9667/nodes=osx11-release-pkg/console succeeded but the parsed 08:08:23 sh tools/osx-notarize.sh v21.0.0-nightly202309295570c29780 08:08:23 objc[10383]: Class AMSupportURLConnectionDelegate is implemented in both /usr/lib/libauthinstall.dylib (0x202f4f490) and /System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x10f3942b8). One of the two will be used. Which one is undefined. 08:08:23 objc[10383]: Class AMSupportURLSession is implemented in both /usr/lib/libauthinstall.dylib (0x202f4f4e0) and /System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x10f394308). One of the two will be used. Which one is undefined. 08:08:23 Notarization process is done with Notarytool. 08:10:23 Notarization submitted. Operation ID: 08:10:23 ssh node-www "mkdir -p nodejs/nightly/v21.0.0-nightly202309295570c29780" Lines 69 to 83 in 6aa7101
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I was able to install the sep 29th on my mac without any messages/complaints so looks to me like it worked. Would be good to get other people to install/test as well to be double sure. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good to me: $ /usr/local/bin/node --version v21.0.0-nightly202309295570c29780 $ spctl -a -vvv -t install /usr/local/bin/node /usr/local/bin/node: accepted source=Notarized Developer ID origin=Developer ID Application: Node.js Foundation (HX7739G8FX) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good in terms of nightlies, removed the don't land tags |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: #48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: #48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: nodejs#48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: nodejs/node#48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Signed-off-by: Ulises Gascon <[email protected]> Refs: nodejs/build#3385 PR-URL: nodejs/node#48701 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Action required by Apple: Transition to the notarytool command-line utility
There was an error while loading. Please reload this page.