GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — url: reduce `pathToFileURL` cpp calls by anonrig · Pull Request #48709 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Jul 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

My local benchmarks show the following changes:

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=1000000 method='fileURLToPath' input='file:///dev/null?key=param&bool'             ***     12.59 %       ±1.21% ±1.62% ±2.12%
url/whatwg-url-to-and-from-path.js n=1000000 method='fileURLToPath' input='file:///dev/null?key=param&bool#hash'        ***      9.72 %       ±0.70% ±0.94% ±1.22%
url/whatwg-url-to-and-from-path.js n=1000000 method='fileURLToPath' input='file:///dev/null'                            ***     18.85 %       ±1.02% ±1.36% ±1.78%
url/whatwg-url-to-and-from-path.js n=1000000 method='pathToFileURL' input='file:///dev/null?key=param&bool'             ***     11.93 %       ±0.78% ±1.04% ±1.35%
url/whatwg-url-to-and-from-path.js n=1000000 method='pathToFileURL' input='file:///dev/null?key=param&bool#hash'        ***     10.31 %       ±0.67% ±0.89% ±1.16%
url/whatwg-url-to-and-from-path.js n=1000000 method='pathToFileURL' input='file:///dev/null'                            ***     18.86 %       ±1.25% ±1.67% ±2.18%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 6 comparisons, you can thus expect the following amount of false-positive results:
  0.30 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.06 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

meyfa, bricss, and gurgunday reacted with heart emoji
All reactions
  • ❤️ 3 reactions
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 9, 2023
@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Jul 9, 2023
Uzlopak
Uzlopak reviewed Jul 9, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@anonrig
anonrig force-pushed the improve-pathToFileURL branch from a864b46 to ce3764d Compare July 9, 2023 18:31
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52673/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca reviewed Jul 10, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig added 2 commits July 11, 2023 15:59
@anonrig
url: reduce pathToFileURL cpp calls
e906e2b
@anonrig
fixup! url: reduce pathToFileURL cpp calls
6d58fe4
@anonrig
anonrig force-pushed the improve-pathToFileURL branch from 99f3dfe to 6d58fe4 Compare July 11, 2023 19:59
@anonrig
anonrig requested a review from lpinca July 11, 2023 19:59
Uzlopak
Uzlopak reviewed Jul 11, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Jul 12, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 12, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52739/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52756/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig

anonrig commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

@nodejs/url ping

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 reviewed Jul 14, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 reviewed Jul 15, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 reviewed Jul 15, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Jul 16, 2023
CI Reliability 2023-07-16 nodejs/reliability#614
Open
23 tasks
Qard
Qard approved these changes Jul 16, 2023
View reviewed changes
aduh95
aduh95 approved these changes Jul 16, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 16, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7196946 into nodejs:main Jul 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7196946

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jul 17, 2023
CI Reliability 2023-07-17 nodejs/reliability#615
Open
CI Reliability 2023-07-18 nodejs/reliability#616
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: reduce pathToFileURL cpp calls
5ea3dfd
PR-URL: nodejs#48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: reduce pathToFileURL cpp calls
868b6fe
PR-URL: nodejs#48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@anonrig @UlisesGascon
url: reduce pathToFileURL cpp calls
6906715
PR-URL: nodejs#48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@anonrig @RafaelGSS
url: reduce pathToFileURL cpp calls
30fb7b7
PR-URL: #48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
url: reduce pathToFileURL cpp calls
2441415
PR-URL: #48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@jgerigmeyer jgerigmeyer mentioned this pull request Dec 15, 2023
v18.18.2 -> v18.19.0, v20.5.1 -> v20.6.0 regression: pathToFileURL trims whitespace. #51167
Closed
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
url: reduce pathToFileURL cpp calls
6e69188
PR-URL: nodejs/node#48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
url: reduce pathToFileURL cpp calls
fb504b7
PR-URL: nodejs/node#48709
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@injunchoi98 injunchoi98 mentioned this pull request Jul 27, 2024
url: encode null character at the end of file path #54066
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@Qard Qard Qard approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@Uzlopak Uzlopak Uzlopak left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@anonrig @nodejs-github-bot @Qard @lpinca @Uzlopak @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.