GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove unnecessary temporary creation by CGQAQ · Pull Request #48734 · nodejs/node

Conversation

@CGQAQ

@CGQAQ CGQAQ commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

The emplace already can create the CleanupHookCallback in place

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@CGQAQ
src: remove unnecessary temporary creation
c66a5bb
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023
@CGQAQ
src: run CLANG_FORMAT_START=$(git merge-base HEAD main) make format-cpp
1f788f1
@aduh95
aduh95 requested a review from legendecas July 15, 2023 17:45
legendecas
legendecas approved these changes Jul 17, 2023
View reviewed changes
@legendecas legendecas added commit-queue-squash PRs the Commit Queue should land as one squashed commit. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52815/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 18, 2023
CI Reliability 2023-07-18 nodejs/reliability#616
Open
CI Reliability 2023-07-19 nodejs/reliability#617
Open
@nodejs-github-bot

nodejs-github-bot commented Jul 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52840/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Jul 19, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jul 20, 2023
CI Reliability 2023-07-20 nodejs/reliability#618
Open
22 tasks
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ce73e88 into nodejs:main Jul 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in ce73e88
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 21, 2023
CI Reliability 2023-07-21 nodejs/reliability#619
Open
CI Reliability 2023-07-22 nodejs/reliability#620
Open
CI Reliability 2023-07-23 nodejs/reliability#621
Open
CI Reliability 2023-07-24 nodejs/reliability#622
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove unnecessary temporary creation
f13f1bf 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove unnecessary temporary creation
5362f85 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@CGQAQ @UlisesGascon
src: remove unnecessary temporary creation
72d134d 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@CGQAQ @RafaelGSS
src: remove unnecessary temporary creation
d759d4f 
PR-URL: #48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@CGQAQ @targos
src: remove unnecessary temporary creation
97d8749 
PR-URL: #48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unnecessary temporary creation
0ef0602 
PR-URL: nodejs/node#48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unnecessary temporary creation
6636a9c 
PR-URL: nodejs/node#48734
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CGQAQ @nodejs-github-bot @anonrig @legendecas @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.