GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: sync JSDoc with the actual implementation by illusi0n7 · Pull Request #48853 · nodejs/node

Conversation

@illusi0n7

@illusi0n7 illusi0n7 commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

JSDoc update was omitted during code implementation

Refs: #46933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@illusi0n7
fs: sync JSDoc with the actual implementation
eddf5cc 
JSDoc update was omitted during code implementation

Refs: nodejs#46933
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Jul 20, 2023
aduh95
aduh95 approved these changes Jul 20, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. typings Issues and PRs related to internal TypeScript declarations. and removed needs-ci PRs that need a full CI run. labels Jul 20, 2023
anonrig
anonrig reviewed Jul 21, 2023
View reviewed changes
Comment thread lib/internal/fs/promises.js
* } ReadableStream
* @param {{
* type?: string;
* }} [options]

@anonrig anonrig Jul 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this indentation correct?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@illusi0n7 illusi0n7 Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is same as the others I think

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
deokjinkim
deokjinkim approved these changes Jul 23, 2023
View reviewed changes
@deokjinkim deokjinkim added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 23, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48853
✔  Done loading data for nodejs/node/pull/48853
----------------------------------- PR info ------------------------------------
Title      fs: sync JSDoc with the actual implementation (#48853)
Author     Hyunjin Kim  (@illusi0n7, first-time contributor)
Branch     illusi0n7:dev/doc -> nodejs:main
Labels     fs, author ready, typings
Commits    1
 - fs: sync JSDoc with the actual implementation
Committers 1
 - Hyunjin Kim 
PR-URL: https://github.com/nodejs/node/pull/48853
Refs: https://github.com/nodejs/node/pull/46933
Reviewed-By: Antoine du Hamel 
Reviewed-By: Deokjin Kim 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48853
Refs: https://github.com/nodejs/node/pull/46933
Reviewed-By: Antoine du Hamel 
Reviewed-By: Deokjin Kim 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 20 Jul 2023 14:26:27 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48853#pullrequestreview-1540155251
   ✔  - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/48853#pullrequestreview-1542182649
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5634524749
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 9c5e272 into nodejs:main Jul 23, 2023
@aduh95

aduh95 commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Landed in 9c5e272, thanks for the contribution 🎉
illusi0n7 reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@illusi0n7 @Ceres6
typings: sync JSDoc with the actual implementation
f7ed4bd 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs#46933
PR-URL: nodejs#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@illusi0n7 @Ceres6
typings: sync JSDoc with the actual implementation
e0dc180 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs#46933
PR-URL: nodejs#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@illusi0n7 @Ceres6
typings: sync JSDoc with the actual implementation
0bb33de 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs#46933
PR-URL: nodejs#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@illusi0n7 @UlisesGascon
typings: sync JSDoc with the actual implementation
094523b 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs#46933
PR-URL: nodejs#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@illusi0n7 @RafaelGSS
typings: sync JSDoc with the actual implementation
be7b511 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: #46933
PR-URL: #48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@illusi0n7 @targos
typings: sync JSDoc with the actual implementation
4d70a2c 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: #46933
PR-URL: #48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
typings: sync JSDoc with the actual implementation
2164ac0 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs/node#46933
PR-URL: nodejs/node#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
typings: sync JSDoc with the actual implementation
3b9317d 
JSDoc comment did not match the actual implementation of
`FileHandle#readableWebStream`.

Refs: nodejs/node#46933
PR-URL: nodejs/node#48853
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments
@deokjinkim deokjinkim deokjinkim approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. fs Issues and PRs related to file-system APIs and the fs module. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@illusi0n7 @nodejs-github-bot @aduh95 @anonrig @deokjinkim
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.