GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: fix test_runner `test:fail` event type by Ethan-Arrowood · Pull Request #48854 · nodejs/node

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

This PR updates the documentation for the test:fail event as highlighted by #48840

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Jul 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. test_runner Issues and PRs related to the test runner subsystem. labels Jul 20, 2023
@Ethan-Arrowood
Ethan-Arrowood force-pushed the docs/test-runner-fail-error branch from 9cc900f to 1cdd0aa Compare July 20, 2023 15:54
Ethan Arrowood
test_runner: fix test_runner test:fail event type
d3dca84
@Ethan-Arrowood
Ethan-Arrowood force-pushed the docs/test-runner-fail-error branch from 1cdd0aa to d3dca84 Compare July 20, 2023 19:03
lpinca
lpinca approved these changes Jul 20, 2023
View reviewed changes
MoLow
MoLow approved these changes Jul 20, 2023
View reviewed changes
atlowChemi
atlowChemi approved these changes Jul 21, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6c08b1f into nodejs:main Jul 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6c08b1f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
Ethan Arrowood @Ceres6
test_runner: fix test_runner test:fail event type
0813257
PR-URL: nodejs#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Ethan Arrowood @Ceres6
test_runner: fix test_runner test:fail event type
d80e1eb
PR-URL: nodejs#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Ethan Arrowood @Ceres6
test_runner: fix test_runner test:fail event type
e57ec7f
PR-URL: nodejs#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
Ethan Arrowood @UlisesGascon
test_runner: fix test_runner test:fail event type
1f8bb19
PR-URL: nodejs#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
Ethan Arrowood @RafaelGSS
test_runner: fix test_runner test:fail event type
4bd5e55
PR-URL: #48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
targos pushed a commit that referenced this pull request Oct 28, 2023
Ethan Arrowood @targos
test_runner: fix test_runner test:fail event type
c2575c8
PR-URL: #48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test_runner test:fail event type
517c3fd
PR-URL: nodejs/node#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test_runner test:fail event type
cec9668
PR-URL: nodejs/node#48854
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Ethan-Arrowood @nodejs-github-bot @lpinca @MoLow @atlowChemi @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.