GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: improved joinDuplicateHeaders definition by OnSuorce · Pull Request #48859 · nodejs/node

Conversation

OnSuorce commented Jul 20, 2023

Copy link

Copy Markdown

Contributor

Improved documentation for joinDuplicateHeaders definition

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          doc: improved joinDuplicateHeaders definition

d0ca2a2

nodejs-github-bot commented Jul 20, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/http
@nodejs/net

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added doc

Issues and PRs related to Node.js documentation.

http Issues and PRs related to the http subsystem. labels

Jul 20, 2023

ShogunPanda approved these changes

Jul 21, 2023

View reviewed changes

mcollina approved these changes

Jul 21, 2023

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jul 21, 2023

marco-ippolito approved these changes

Jul 21, 2023

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jul 21, 2023

nodejs-github-bot commented Jul 21, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52883/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Jul 21, 2023

View reviewed changes

Comment thread

doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca commented Jul 21, 2023

Copy link

Copy Markdown

Member

s/improved/improve/ in commit message.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jul 22, 2023

CI Reliability 2023-07-22 nodejs/reliability#620

Open

CI Reliability 2023-07-23 nodejs/reliability#621

Open

CI Reliability 2023-07-24 nodejs/reliability#622

Open

CI Reliability 2023-07-25 nodejs/reliability#623

Open

aymen94 approved these changes

Jul 25, 2023

View reviewed changes


          doc: Improved documentation for joinDuplicateHeaders definition with …

6fd16ac

…suggestion

Co-authored-by: Luigi Pinca <[email protected]>

This was referenced Jul 26, 2023

CI Reliability 2023-07-26 nodejs/reliability#624

Open

CI Reliability 2023-07-27 nodejs/reliability#625

Open

CI Reliability 2023-07-28 nodejs/reliability#626

Open

mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label

Jul 28, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Jul 28, 2023

nodejs-github-bot commented Jul 28, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/48859
✔  Done loading data for nodejs/node/pull/48859
----------------------------------- PR info ------------------------------------
Title      doc: improved joinDuplicateHeaders definition (#48859)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     OnSuorce:pippo_pluto_paperino -> nodejs:main
Labels     http, doc
Commits    2
 - doc: improved joinDuplicateHeaders definition
 - doc: Improved documentation for joinDuplicateHeaders definition with …
Committers 2
 - Matteo Bianchi 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48859
Reviewed-By: Paolo Insogna 
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48859
Reviewed-By: Paolo Insogna 
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: Improved documentation for joinDuplicateHeaders definition with …
   ℹ  This PR was created on Thu, 20 Jul 2023 20:06:42 GMT
   ✔  Approvals: 4
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540666443
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540704845
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540708447
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48859#pullrequestreview-1541219659
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/5690667896

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina approved these changes

Jul 28, 2023

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Jul 28, 2023

nodejs-github-bot commented Jul 28, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/48859 ✔ Done loading data for nodejs/node/pull/48859 ----------------------------------- PR info ------------------------------------ Title doc: improved joinDuplicateHeaders definition (#48859) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch OnSuorce:pippo_pluto_paperino -> nodejs:main Labels http, doc Commits 2 - doc: improved joinDuplicateHeaders definition - doc: Improved documentation for joinDuplicateHeaders definition with … Committers 2 - Matteo Bianchi - GitHub PR-URL: https://github.com/nodejs/node/pull/48859 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48859 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 20 Jul 2023 20:06:42 GMT ✔ Approvals: 4 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540666443 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48859#pullrequestreview-1551772240 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540708447 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48859#pullrequestreview-1541219659 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48859 From https://github.com/nodejs/node * branch refs/pull/48859/merge -> FETCH_HEAD ✔ Fetched commits as 48345d0f6212..6fd16accaa00 -------------------------------------------------------------------------------- Auto-merging doc/api/http.md [main decba93713] doc: improved joinDuplicateHeaders definition Author: Matteo Bianchi Date: Thu Jul 20 22:04:35 2023 +0200 1 file changed, 5 insertions(+), 4 deletions(-) Auto-merging doc/api/http.md [main 739d49b1cb] doc: Improved documentation for joinDuplicateHeaders definition with suggestion Author: Matteo Bianchi <[email protected]> Date: Wed Jul 26 00:11:53 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: improved joinDuplicateHeaders definition

PR-URL: #48859
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD d838984e02] doc: improved joinDuplicateHeaders definition
Author: Matteo Bianchi [email protected]
Date: Thu Jul 20 22:04:35 2023 +0200
1 file changed, 5 insertions(+), 4 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: Improved documentation for joinDuplicateHeaders definition with suggestion

Co-authored-by: Luigi Pinca [email protected]
PR-URL: #48859
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 2086d3ed8c] doc: Improved documentation for joinDuplicateHeaders definition with suggestion
Author: Matteo Bianchi [email protected]
Date: Wed Jul 26 00:11:53 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5690765380

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina added commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Jul 28, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jul 28, 2023

nodejs-github-bot merged commit 8f0f17e into nodejs:main

Jul 28, 2023

nodejs-github-bot commented Jul 28, 2023

Copy link

Copy Markdown

Collaborator

Landed in 8f0f17e

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Jul 29, 2023

CI Reliability 2023-07-29 nodejs/reliability#627

Open

23 tasks

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023


          doc: improved joinDuplicateHeaders definition

e8d4226

PR-URL: nodejs#48859
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023


          doc: improved joinDuplicateHeaders definition

66c5b23

PR-URL: nodejs#48859
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request

Aug 14, 2023


          doc: improved joinDuplicateHeaders definition

6817a16

PR-URL: nodejs#48859
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Aug 15, 2023


          doc: improved joinDuplicateHeaders definition

4c26335

PR-URL: #48859
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon mentioned this pull request

Aug 15, 2023

v20.6.0 proposal #49185

Merged

RafaelGSS pushed a commit that referenced this pull request

Aug 17, 2023


          doc: improved joinDuplicateHeaders definition

f3d62ab

PR-URL: #48859
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Reviewers

mcollina

mcollina approved these changes

ShogunPanda

ShogunPanda approved these changes

lpinca

lpinca approved these changes

marco-ippolito

marco-ippolito approved these changes

+1 more reviewer

aymen94

aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

doc

Issues and PRs related to Node.js documentation.

http

Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

OnSuorce commented Jul 20, 2023

Uh oh!

nodejs-github-bot commented Jul 20, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 21, 2023

Uh oh!

Uh oh!

lpinca commented Jul 21, 2023

Uh oh!

nodejs-github-bot commented Jul 28, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 28, 2023

PR-URL: #48859 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: Matteo Collina [email protected] Reviewed-By: Marco Ippolito [email protected] Reviewed-By: Luigi Pinca [email protected]

Co-authored-by: Luigi Pinca [email protected] PR-URL: #48859 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: Matteo Collina [email protected] Reviewed-By: Marco Ippolito [email protected] Reviewed-By: Luigi Pinca [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Jul 28, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

PR-URL: #48859
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Luigi Pinca [email protected]

Co-authored-by: Luigi Pinca [email protected]
PR-URL: #48859
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Luigi Pinca [email protected]