GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs : doc readdir recursive sync & callback #48640 · Pull Request #48902 · nodejs/node

Conversation

@ghost

@ghost ghost commented Jul 24, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes: #48640

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module. labels Jul 24, 2023
lpinca
lpinca approved these changes Jul 26, 2023
View reviewed changes
Comment thread doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig
anonrig approved these changes Sep 30, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 30, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48902
✔  Done loading data for nodejs/node/pull/48902
----------------------------------- PR info ------------------------------------
Title      fs : doc readdir recursive sync & callback #48640 (#48902)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RamdohokarAngha:fs-doc-readdir-recursive-sync-&-callback -> nodejs:main
Labels     doc, fs, author ready, commit-queue-squash
Commits    4
 - fs : doc readdir recursive sync & callback
 - Update doc/api/fs.md
 - Update doc/api/fs.md
 - Merge branch 'nodejs:main' into fs-doc-readdir-recursive-sync-&-callback
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48902
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48902
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 24 Jul 2023 11:40:08 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48902#pullrequestreview-1548446213
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48902#pullrequestreview-1651609728
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48902
From https://github.com/nodejs/node
 * branch                  refs/pull/48902/merge -> FETCH_HEAD
✔  Fetched commits as 51f4ff245018..e2cfe24fc05a
--------------------------------------------------------------------------------
Auto-merging doc/api/fs.md
[main 5931ae8cee] fs : doc readdir recursive sync & callback
 Author: RamdohokarAngha <[email protected]>
 Date: Mon Jul 24 17:06:51 2023 +0530
 1 file changed, 6 insertions(+), 3 deletions(-)
Auto-merging doc/api/fs.md
[main 422bc6de18] Update doc/api/fs.md
 Author: RamdohokarAngha <[email protected]>
 Date: Wed Aug 16 11:37:49 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging doc/api/fs.md
error: commit e2cfe24fc05a82df5feff180c6dc5296e6a6f79c is a merge but no -m option was given.
fatal: cherry-pick failed
[main 1f365ad1d5] Update doc/api/fs.md
 Author: RamdohokarAngha <[email protected]>
 Date: Wed Aug 16 11:38:07 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/6359670729
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RamdohokarAngha and others added 2 commits October 6, 2023 15:45
RamdohokarAngha @aduh95
doc: fix description of fs.readdir recursive option
966c473
@aduh95
fixup! doc: fix description of fs.readdir recursive option
0c48466
aduh95
aduh95 approved these changes Oct 6, 2023
View reviewed changes
@KuthorX

KuthorX commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

associated with #48640

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 34fa704 into nodejs:main Oct 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 34fa704

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS mentioned this pull request Oct 10, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
RamdohokarAngha @targos
doc: fix description of fs.readdir recursive option
3d03ca9
PR-URL: #48902
Fixes: #48640
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
RamdohokarAngha @debadree25
doc: fix description of fs.readdir recursive option
0345207
PR-URL: nodejs#48902
Fixes: nodejs#48640
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.readdir's new recursive option is not fully documented

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nodejs-github-bot @KuthorX @lpinca @anonrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.