GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src,permission: restrict by default when pm enabled by RafaelGSS · Pull Request #48907 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Jul 24, 2023

Copy link
Copy Markdown
Member

It goes according to the documentation:

When starting Node.js with --experimental-permission, the ability to access the file system through the fs module, spawn processes, use node:worker_threads and enable the runtime inspector will be restricted.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 24, 2023
@RafaelGSS
RafaelGSS force-pushed the fix/restrict-by-default-pm-enabled branch from f1068f9 to cf6a089 Compare July 24, 2023 18:43
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52922/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jul 24, 2023
View reviewed changes
lpinca
lpinca reviewed Jul 24, 2023
View reviewed changes
Comment thread test/parallel/test-permission-inspector.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Jul 24, 2023
View reviewed changes
@RafaelGSS
src,permission: restrict by default when pm enabled
4ff3b90
@RafaelGSS
RafaelGSS force-pushed the fix/restrict-by-default-pm-enabled branch from cf6a089 to 4ff3b90 Compare July 24, 2023 20:43
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52923/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jul 25, 2023
CI Reliability 2023-07-25 nodejs/reliability#623
Open
14 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52924/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52926/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 25, 2023
@github-actions github-actions Bot mentioned this pull request Jul 26, 2023
CI Reliability 2023-07-26 nodejs/reliability#624
Open
14 tasks
ShogunPanda
ShogunPanda approved these changes Jul 26, 2023
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Jul 26, 2023
View reviewed changes
@RafaelGSS RafaelGSS added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 14e7bd8 into nodejs:main Jul 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 14e7bd8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jul 27, 2023
CI Reliability 2023-07-27 nodejs/reliability#625
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
06fbbb8 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jul 28, 2023
CI Reliability 2023-07-28 nodejs/reliability#626
Open
19 tasks
@github-actions github-actions Bot mentioned this pull request Jul 31, 2023
CI Reliability 2023-07-31 nodejs/reliability#629
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
d33d4a6 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src,permission: restrict by default when pm enabled
0ccb1d0 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@RafaelGSS @UlisesGascon
src,permission: restrict by default when pm enabled
6c05dd8 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS added a commit that referenced this pull request Aug 15, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
833e571 
PR-URL: #48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS added a commit that referenced this pull request Aug 17, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
62a46d9 
PR-URL: #48907
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RafaelGSS @nodejs-github-bot @ShogunPanda @lpinca @targos @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.