GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix todo and only in spec reporter by MoLow · Pull Request #48929 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Jul 26, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MoLow
MoLow requested review from atlowChemi, benjamingr and cjihrig July 26, 2023 11:39
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 26, 2023
atlowChemi
atlowChemi approved these changes Jul 26, 2023
View reviewed changes
@MoLow
MoLow force-pushed the test-runner-fix-todo-and-only branch from fe46cc8 to 900724d Compare July 26, 2023 11:43
atlowChemi
atlowChemi approved these changes Jul 26, 2023
View reviewed changes
cjihrig
cjihrig reviewed Jul 26, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js Outdated

@cjihrig cjihrig Jul 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you making a TODO into a noop? A TODO test should still run, but not fail the test suite if the test fails.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi reacted with eyes emoji
All reactions
  • 👀 1 reaction

@MoLow MoLow Jul 26, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think it never has behaved that way :/ anyway I,l revert this part and keep only the reporter fixes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cjihrig cjihrig Jul 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verified that todo tests show up as todo in the summary, but incorrectly set the process exit code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@MoLow MoLow Jul 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a fix in a separate commit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MoLow
MoLow force-pushed the test-runner-fix-todo-and-only branch from 900724d to e1e795c Compare July 26, 2023 19:19
@MoLow
MoLow requested a review from cjihrig July 26, 2023 19:20
@MoLow MoLow added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Jul 26, 2023
cjihrig
cjihrig approved these changes Jul 26, 2023
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

By the way, if anyone reading this is interested in doing more TODO test work, the TAP spec mentions that these tests are intended to fail and if they start passing, the test runner may report that in some way so that the user can drop the TODO designation. I think we already have all of the machinery in place to implement that fairly easily.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/internal/main/test_runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/fixtures/test-runner/output/describe_it.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/fixtures/test-runner/output/describe_it.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow added 2 commits July 26, 2023 22:53
@MoLow
test_runner: fix todo and only in spec reporter
cd87bb0
@MoLow
test_runner: dont set exit code on todo tests
e8c3f01
@MoLow
MoLow force-pushed the test-runner-fix-todo-and-only branch from e1e795c to e8c3f01 Compare July 26, 2023 19:58
@MoLow
MoLow requested a review from cjihrig July 26, 2023 19:58
cjihrig
cjihrig approved these changes Jul 26, 2023
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 26, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52945/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jul 27, 2023
CI Reliability 2023-07-27 nodejs/reliability#625
Open
18 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52950/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Jul 27, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52952/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jul 27, 2023
View reviewed changes
This was referenced Jul 28, 2023
CI Reliability 2023-07-28 nodejs/reliability#626
Open
CI Reliability 2023-07-29 nodejs/reliability#627
Open
This was referenced Jul 30, 2023
CI Reliability 2023-07-30 nodejs/reliability#628
Open
CI Reliability 2023-07-31 nodejs/reliability#629
Open
CI Reliability 2023-08-01 nodejs/reliability#630
Open
CI Reliability 2023-08-02 nodejs/reliability#631
Open
@MoLow MoLow mentioned this pull request Aug 10, 2023
Looking for clarity on test runner reporting and skip/todo #49013
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix todo and only in spec reporter
fde0b39 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont set exit code on todo tests
21befee 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix todo and only in spec reporter
95e271e 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont set exit code on todo tests
74622bf 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@MoLow @UlisesGascon
test_runner: fix todo and only in spec reporter
7950f59 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@MoLow @UlisesGascon
test_runner: dont set exit code on todo tests
d919d76 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@MoLow @RafaelGSS
test_runner: fix todo and only in spec reporter
0324c80 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@MoLow @RafaelGSS
test_runner: dont set exit code on todo tests
56d0958 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@MoLow @RafaelGSS
test_runner: fix todo and only in spec reporter
20269a0 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@MoLow @RafaelGSS
test_runner: dont set exit code on todo tests
454d8dc 
PR-URL: nodejs#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@MoLow @RafaelGSS
test_runner: fix todo and only in spec reporter
52c9490 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@MoLow @RafaelGSS
test_runner: dont set exit code on todo tests
9136667 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cjihrig cjihrig mentioned this pull request Oct 23, 2023
parallel/test-dotenv-node-options skipped #50346
Closed
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow @targos
test_runner: fix todo and only in spec reporter
d217435 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow @targos
test_runner: dont set exit code on todo tests
00c70e1 
PR-URL: #48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix todo and only in spec reporter
44483cc 
PR-URL: nodejs/node#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: dont set exit code on todo tests
e8d4aab 
PR-URL: nodejs/node#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix todo and only in spec reporter
aacf0c0 
PR-URL: nodejs/node#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: dont set exit code on todo tests
00d32a2 
PR-URL: nodejs/node#48929
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MoLow @nodejs-github-bot @benjamingr @cjihrig @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.