GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify use of process.env in worker threads on Windows by daeyeon · Pull Request #49008 · nodejs/node

Conversation

@daeyeon

@daeyeon daeyeon commented Aug 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A worker thread uses a copy of parent thread's process.env by default. The current document explains differences caused by the copy, but it doesn't cover the case sensitivity difference on Windows.

This patch updates the document in this regard.

Fixes: #48955
Alternative to #48976

Signed-off-by: Daeyeon Jeong [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daeyeon
doc: clarify use of process.env in worker threads on Windows
6217170
Signed-off-by: Daeyeon Jeong <[email protected]>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Aug 3, 2023
lpinca
lpinca approved these changes Aug 3, 2023
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Aug 3, 2023
View reviewed changes
deokjinkim
deokjinkim approved these changes Aug 3, 2023
View reviewed changes
anonrig
anonrig approved these changes Aug 4, 2023
View reviewed changes
@atlowChemi atlowChemi added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 4, 2023
RaisinTen
RaisinTen approved these changes Aug 4, 2023
View reviewed changes
aymen94
aymen94 approved these changes Aug 4, 2023
View reviewed changes
tniessen
tniessen approved these changes Aug 5, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d150316 into nodejs:main Aug 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in d150316

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daeyeon
daeyeon deleted the main.doc-worker-env-230803.Thu.38c0 branch August 6, 2023 02:06
@daeyeon daeyeon mentioned this pull request Aug 6, 2023
worker: support case-insensitive process.env usage on Windows in worker threads #48976
Closed
@leumasme leumasme mentioned this pull request Aug 7, 2023
Terminal Intercepting crashes when using NodeJS worker threads httptoolkit/httptoolkit-server#91
Closed
@daeyeon daeyeon mentioned this pull request Aug 8, 2023
In worker threads, process.env is case-sensitive on windows #48955
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@daeyeon @Ceres6
doc: clarify use of process.env in worker threads on Windows
d873a2c
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@daeyeon @Ceres6
doc: clarify use of process.env in worker threads on Windows
ffe7ba3
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@daeyeon @UlisesGascon
doc: clarify use of process.env in worker threads on Windows
fbf5383
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
e5e5fd5
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
530ae44
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
9c26c0f
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@daeyeon @targos
doc: clarify use of process.env in worker threads on Windows
ead654f
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: clarify use of process.env in worker threads on Windows
0f160a2
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs/node#49008
Fixes: nodejs/node#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: clarify use of process.env in worker threads on Windows
8ea60a1
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs/node#49008
Fixes: nodejs/node#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@coderabbitai coderabbitai Bot mentioned this pull request Aug 2, 2026
chore: improve dev env and builds viscalyx/Kravhantering#713
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen tniessen approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In worker threads, process.env is case-sensitive on windows

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@daeyeon @nodejs-github-bot @bnoordhuis @lpinca @anonrig @tniessen @deokjinkim @aymen94 @RaisinTen @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.