GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add h1 summary to security release process by RafaelGSS · Pull Request #49112 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Aug 11, 2023

Copy link
Copy Markdown
Member

This has proven quite useful to either request disclosure on H1 and create the pos release announcement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Aug 11, 2023
MoLow
MoLow approved these changes Aug 12, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mcollina
mcollina approved these changes Aug 13, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhdawson
mhdawson approved these changes Aug 14, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
doc: add h1 summary to security release process
97b946d
@RafaelGSS
RafaelGSS force-pushed the doc/add-summary-to-security-release-process branch from ba88713 to 97b946d Compare August 14, 2023 19:28
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49112
✔  Done loading data for nodejs/node/pull/49112
----------------------------------- PR info ------------------------------------
Title      doc: add h1 summary to security release process (#49112)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/add-summary-to-security-release-process -> nodejs:main
Labels     doc
Commits    1
 - doc: add h1 summary to security release process
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/49112
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49112
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: add h1 summary to security release process
   ℹ  This PR was created on Fri, 11 Aug 2023 21:13:42 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575388082
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575728794
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1577361439
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5861382314
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 17, 2023
mhdawson
mhdawson approved these changes Aug 17, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3af6585 into nodejs:main Aug 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3af6585
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@RafaelGSS @UlisesGascon
doc: add h1 summary to security release process
3df2251 
PR-URL: #49112
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@RafaelGSS @targos
doc: add h1 summary to security release process
2247e52 
PR-URL: #49112
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add h1 summary to security release process
0c182d9 
PR-URL: nodejs/node#49112
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add h1 summary to security release process
c9b7fcb 
PR-URL: nodejs/node#49112
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RafaelGSS @nodejs-github-bot @mcollina @MoLow @mhdawson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.