GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gyp: put cctest filenames in variables by zcbenz · Pull Request #49178 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

This is a followup to #46965, which will be very helpful for #47637.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zcbenz
gyp: put cctest filenames in variables
219b4d2
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Aug 15, 2023
targos
targos approved these changes Aug 15, 2023
View reviewed changes
gengjiawen
gengjiawen approved these changes Aug 15, 2023
View reviewed changes
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2023
joyeecheung
joyeecheung approved these changes Aug 15, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53344/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 15, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 18, 2023
CI Reliability 2023-08-18 nodejs/reliability#640
Open
32 tasks
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53475/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Aug 21, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 22, 2023
CI Reliability 2023-08-22 nodejs/reliability#642
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53491/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 23, 2023
CI Reliability 2023-08-23 nodejs/reliability#643
Open
CI Reliability 2023-08-24 nodejs/reliability#644
Open
CI Reliability 2023-08-25 nodejs/reliability#645
Open
CI Reliability 2023-08-26 nodejs/reliability#646
Open
CI Reliability 2023-08-27 nodejs/reliability#647
Open
@zcbenz zcbenz mentioned this pull request Sep 8, 2023
build: add GN build files #47637
Merged
Qard
Qard approved these changes Sep 8, 2023
View reviewed changes
@Qard Qard added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3163f8d into nodejs:main Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3163f8d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@zcbenz @ruyadorno
gyp: put cctest filenames in variables
0f020ed 
PR-URL: #49178
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
@zcbenz zcbenz mentioned this pull request Nov 28, 2023
Things blocking a full-featured GN build of upstream Node.js photoionization/node_with_gn#1
Closed
26 of 27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@zcbenz @nodejs-github-bot @Qard @anonrig @targos @gengjiawen @joyeecheung @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.