GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: expose spec reporter as newable function by atlowChemi · Pull Request #49184 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented Aug 15, 2023

Copy link
Copy Markdown
Member

Fixes: #48112
Ref: #48208

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 15, 2023
@atlowChemi
atlowChemi force-pushed the spec-reporter-as-function branch 2 times, most recently from 7a2f61e to f217312 Compare August 15, 2023 18:20
@atlowChemi atlowChemi added test_runner Issues and PRs related to the test runner subsystem. and removed test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Aug 15, 2023
View reviewed changes
MoLow
MoLow approved these changes Aug 15, 2023
View reviewed changes
@MoLow

MoLow commented Aug 15, 2023

Copy link
Copy Markdown
Member

@atlowChemi can you amend the commit message changing from expose test_runner as newable function to expose spec reporter as newable function
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi

atlowChemi commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@atlowChemi can you amend the commit message changing from expose test_runner as newable function to expose spec reporter as newable function

Oh, of course. That was what I meant, oopsy 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
test_runner: expose spec reporter as newable function
193c63a 
Fixes: nodejs#48112
Ref: nodejs#48208
@atlowChemi
atlowChemi force-pushed the spec-reporter-as-function branch from f217312 to 193c63a Compare August 16, 2023 05:05
@atlowChemi

atlowChemi commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@MoLow fixed commit message, care to re-approve latest commit? 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53370/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Aug 16, 2023
View reviewed changes
@MoLow MoLow changed the title test_runner: expose test_runner as newable function test_runner: expose spec reporter as newable function Aug 16, 2023
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a5567c2 into nodejs:main Aug 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in a5567c2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi deleted the spec-reporter-as-function branch August 17, 2023 18:37
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@atlowChemi @UlisesGascon
test_runner: expose spec reporter as newable function
283f280 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
@aduh95 aduh95 mentioned this pull request Oct 13, 2023
impossible to use spec test reporter without new #50176
Closed
targos pushed a commit that referenced this pull request Nov 27, 2023
@atlowChemi @targos
test_runner: expose spec reporter as newable function
95cc98e 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@atlowChemi atlowChemi mentioned this pull request Apr 7, 2024
test_runner: expose lcov reporter as newable function #52403
Merged
atlowChemi added a commit to atlowChemi/node that referenced this pull request Apr 14, 2024
@atlowChemi
test_runner: expose lcov reporter as newable function
8c31349 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: nodejs#52385
Ref: nodejs#49184
nodejs-github-bot pushed a commit that referenced this pull request Apr 15, 2024
@atlowChemi
test_runner: expose lcov reporter as newable function
0db38f0 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: expose spec reporter as newable function
6d13858 
Fixes: nodejs/node#48112
Ref: nodejs/node#48208
PR-URL: nodejs/node#49184
Refs: nodejs/node#48208
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: expose spec reporter as newable function
2bc5396 
Fixes: nodejs/node#48112
Ref: nodejs/node#48208
PR-URL: nodejs/node#49184
Refs: nodejs/node#48208
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 30, 2024
@atlowChemi @aduh95
test_runner: expose lcov reporter as newable function
df1080e 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@benjamingr benjamingr mentioned this pull request May 11, 2024
test_runner: handled change for exposing 'spec' reporter #48202
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specify that spec reporter is a class and needs to be instantiate for usage with run

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@atlowChemi @nodejs-github-bot @MoLow @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.