GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: mention nodejs/tsc when changing GH templates by RafaelGSS · Pull Request #49189 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Aug 15, 2023

Copy link
Copy Markdown
Member

I noticed while creating #49188 that no one is notified when a PR is created attempting to change our GitHub templates. I believe makes sense to mention nodejs/tsc in this case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Khalilheyrani6367 reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
Khalilheyrani6367 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS changed the title meta: mention nodejs/tsc when chaning GH templates meta: mention nodejs/tsc when changing GH templates Aug 15, 2023
@RafaelGSS
meta: mention nodejs/tsc when changing GH templates
25d2838
@RafaelGSS
RafaelGSS force-pushed the meta/update-codeowners-gh-template branch from d786e0e to 25d2838 Compare August 15, 2023 21:13
anonrig
anonrig approved these changes Aug 15, 2023
View reviewed changes
MoLow
MoLow approved these changes Aug 15, 2023
View reviewed changes
trivikr
trivikr approved these changes Aug 16, 2023
View reviewed changes
targos
targos approved these changes Aug 16, 2023
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Aug 16, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Aug 16, 2023
View reviewed changes
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c021b27 into nodejs:main Aug 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in c021b27

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@RafaelGSS @UlisesGascon
meta: mention nodejs/tsc when changing GH templates
ab97523
PR-URL: #49189
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@RafaelGSS @targos
meta: mention nodejs/tsc when changing GH templates
bd17f0b
PR-URL: #49189
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: mention nodejs/tsc when changing GH templates
797f471
PR-URL: nodejs/node#49189
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: mention nodejs/tsc when changing GH templates
8db5101
PR-URL: nodejs/node#49189
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@MoLow MoLow MoLow approved these changes
@trivikr trivikr trivikr approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@RafaelGSS @nodejs-github-bot @anonrig @targos @gireeshpunathil @MoLow @trivikr @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.