GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix compiler warning in NodeCryptoEnv by tniessen · Pull Request #49206 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Aug 16, 2023

Copy link
Copy Markdown
Member

This fixes warning: value computed is not used when calling BIO_seek():

../test/cctest/test_node_crypto_env.cc: In member function ‘virtual void NodeCryptoEnv_LoadBIO_Test::TestBody()’:
../deps/openssl/openssl/include/openssl/../../../config/././archs/linux-x86_64/asm/include/openssl/bio.h:495:26: warning: value computed is not used [-Wunused-value]
  495 | # define BIO_seek(b,ofs) (int)BIO_ctrl(b,BIO_C_FILE_SEEK,ofs,NULL)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../test/cctest/test_node_crypto_env.cc:26:3: note: in expansion of macro ‘BIO_seek’
   26 |   BIO_seek(bio.get(), 2);
      |   ^~~~~~~~

Refs: #47160

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
test: fix compiler warning in NodeCryptoEnv
5d79fb2 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs#47160
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 16, 2023
@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. review wanted PRs that need review. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 20, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53528/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Aug 23, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen tniessen removed the review wanted PRs that need review. label Aug 23, 2023
@github-actions github-actions Bot mentioned this pull request Aug 24, 2023
CI Reliability 2023-08-24 nodejs/reliability#644
Open
27 tasks
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6117cc3 into nodejs:main Aug 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6117cc3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 25, 2023
CI Reliability 2023-08-25 nodejs/reliability#645
Open
CI Reliability 2023-08-26 nodejs/reliability#646
Open
CI Reliability 2023-08-27 nodejs/reliability#647
Open
CI Reliability 2023-08-28 nodejs/reliability#648
Open
CI Reliability 2023-08-29 nodejs/reliability#649
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
test: fix compiler warning in NodeCryptoEnv
a11e64e 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: #47160
PR-URL: #49206
Reviewed-By: Michael Dawson <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@tniessen @targos
test: fix compiler warning in NodeCryptoEnv
ddebd29 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: #47160
PR-URL: #49206
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix compiler warning in NodeCryptoEnv
4308c16 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs/node#47160
PR-URL: nodejs/node#49206
Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix compiler warning in NodeCryptoEnv
b78535c 
This fixes a warning in line 26: "warning: value computed is not used"
when calling BIO_seek().

Refs: nodejs/node#47160
PR-URL: nodejs/node#49206
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tniessen @nodejs-github-bot @mhdawson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.