GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: migrate message source map tests from Python to JS by yiyunlei · Pull Request #49238 · nodejs/node

Conversation

@yiyunlei

@yiyunlei yiyunlei commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Some JS files are detected as deleted and newly created even though they are very similar. I also mentioned the reason here #47707 (comment). IMHO, it is because the default similarity index for git diff is 50%.

Same for most .snapshot files ( they are also detected as deleted ), the main difference between the original .out file and the .snapshot file is .snapshot files have more details like Object.<anonymous>.

Example:

  • node/test/fixtures/source-map/output/source_map_throw_catch.snapshot
reachable
Error: an exception
    at branch (*typescript-throw.ts:18:11)
    at Object.<anonymous> (*typescript-throw.ts:24:1)
  • node/test/message/source_map_throw_catch.out
reachable
Error: an exception
    at *typescript-throw.ts:18:11*
    at *typescript-throw.ts:24:1*

Should I replace these Object.<anonymous>?

Also, #47707 (comment)

In the latest code version, the tests for source_map_disabled_by_api.js and source_map_enabled_by_api.js are failing because of the change in the commit #46391.

Should I update the .snapshot files for them accordingly ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gurgunday and bricss reacted with thumbs up emoji gurgunday and bricss reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🚀 2 reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 19, 2023
@yiyunlei
yiyunlei marked this pull request as draft August 19, 2023 05:28
@yiyunlei
yiyunlei marked this pull request as ready for review August 19, 2023 05:28
@yiyunlei yiyunlei mentioned this pull request Aug 19, 2023
message tests can be migrated from python to JS #47707
Closed
MoLow
MoLow approved these changes Aug 19, 2023
View reviewed changes
@MoLow

MoLow commented Aug 19, 2023

Copy link
Copy Markdown
Member

Thanks for this work! I don't think we need to make such an effort for git to detect these as renames as long as reviewing these PRs makes sense and doesn't include hundreds of files :)

also, please fix lint errors and amend the commit message for it to comply with guidlines

yiyunlei reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yiyunlei

yiyunlei commented Aug 22, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for your review. I have updated the commit message and the code according to Lint.

MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yiyunlei
yiyunlei requested a review from MoLow August 22, 2023 17:58
@yiyunlei
yiyunlei force-pushed the node47707-migrate-message-tests-source-map branch from 46d42ca to bee982b Compare August 22, 2023 23:15
@MoLow

MoLow commented Aug 23, 2023

Copy link
Copy Markdown
Member

commits still don't adhere guidelines

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yiyunlei
yiyunlei force-pushed the node47707-migrate-message-tests-source-map branch 2 times, most recently from 0a273de to e154b45 Compare August 24, 2023 16:36
Yiyun Lei
test: migrate message source map tests from Python to JS
0991cb3
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707

test: migrate message source map tests from Python to JS
@yiyunlei
yiyunlei force-pushed the node47707-migrate-message-tests-source-map branch from e154b45 to 0991cb3 Compare August 24, 2023 16:42
@yiyunlei

yiyunlei commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

I squashed my commits, hope it works this time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Aug 27, 2023
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53577/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Aug 28, 2023
CI Reliability 2023-08-28 nodejs/reliability#648
Open
25 tasks
@yiyunlei

yiyunlei commented Aug 28, 2023

Copy link
Copy Markdown
Contributor Author

Hi @MoLow, how can I pass the failed tests?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Aug 29, 2023
CI Reliability 2023-08-29 nodejs/reliability#649
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53601/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow

MoLow commented Aug 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

how can I pass the failed tests?

I ran a rebuild

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53603/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53604/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9cd70f4 into nodejs:main Aug 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9cd70f4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow

MoLow commented Aug 29, 2023

Copy link
Copy Markdown
Member

@yiyunlei thanks for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yiyunlei

yiyunlei commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

@MoLow Thanks for your review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Aug 30, 2023
CI Reliability 2023-08-30 nodejs/reliability#650
Open
CI Reliability 2023-08-31 nodejs/reliability#651
Open
CI Reliability 2023-09-01 nodejs/reliability#652
Open
CI Reliability 2023-09-02 nodejs/reliability#653
Open
CI Reliability 2023-09-03 nodejs/reliability#654
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Yiyun Lei @UlisesGascon
test: migrate message source map tests from Python to JS
48e4156
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: #47707

test: migrate message source map tests from Python to JS
PR-URL: #49238
Reviewed-By: Moshe Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
Yiyun Lei @targos
test: migrate message source map tests from Python to JS
107015b
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: #47707

test: migrate message source map tests from Python to JS
PR-URL: #49238
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: migrate message source map tests from Python to JS
9c2c96a
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: nodejs/node#47707

test: migrate message source map tests from Python to JS
PR-URL: nodejs/node#49238
Reviewed-By: Moshe Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: migrate message source map tests from Python to JS
cd5f216
Migrate the remaining source map tests in the `test/message` folder
from Python to JS.

Fixes: nodejs/node#47707

test: migrate message source map tests from Python to JS
PR-URL: nodejs/node#49238
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@yiyunlei @MoLow @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.