GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: edit `import.meta.resolve` documentation by aduh95 · Pull Request #49247 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Aug 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • add missing history entry.
  • fix the return value description:
    • The return value doesn't have to be a file: URL, it can be of any scheme.
    • The return value doesn't have to correspond to a module, it can be a directory or something that doesn't exist.
  • merge the two code examples, remove the use of the non-standard second argument.
  • merge the two caveats.
  • do not mention the old implementation, the history section is already there for that.

Refs: #49028

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
JakobJingleheimer
JakobJingleheimer reviewed Aug 19, 2023
View reviewed changes
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Aug 19, 2023
View reviewed changes
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
guybedford
guybedford approved these changes Aug 19, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 19, 2023
@GeoffreyBooth GeoffreyBooth added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 19, 2023
@github-actions

github-actions Bot commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth

GeoffreyBooth commented Aug 19, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adding fast-track PRs proposed for a shorter-than-standard waiting period before landing. in case it’s possible to add this to Monday’s release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth mentioned this pull request Aug 19, 2023
v20.6.0 proposal #49185
Merged
aymen94
aymen94 approved these changes Aug 21, 2023
View reviewed changes
@joyeecheung

joyeecheung commented Aug 27, 2023

Copy link
Copy Markdown
Member

This needs a rebase
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 added 3 commits September 4, 2023 23:01
@aduh95
doc: edit import.meta.resolve documentation
ec47440
@aduh95
fixup! doc: edit import.meta.resolve documentation
3d69edb
@aduh95
fixup! doc: edit import.meta.resolve documentation
d20e630
@aduh95
aduh95 force-pushed the import-meta-resolve branch from 6f1be92 to d20e630 Compare September 4, 2023 21:02
@aduh95 aduh95 removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 4, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Sep 5, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e11c7b7 into nodejs:main Sep 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in e11c7b7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the import-meta-resolve branch September 5, 2023 08:06
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
doc: edit import.meta.resolve documentation
b9d4a80 
PR-URL: #49247
Refs: #49028
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
doc: edit import.meta.resolve documentation
16580a4 
PR-URL: nodejs#49247
Refs: nodejs#49028
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed
@targos targos added the backported-to-v18.x label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
doc: edit import.meta.resolve documentation
c20fdb4 
PR-URL: #49247
Backport-PR-URL: #50669
Refs: #49028
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
11700d7 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
054b934 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@guybedford guybedford guybedford approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @nodejs-github-bot @GeoffreyBooth @joyeecheung @guybedford @JakobJingleheimer @aymen94 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.