GeezerVison

- Loading data for nodejs/node/pull/49249
✔  Done loading data for nodejs/node/pull/49249
----------------------------------- PR info ------------------------------------
Title      stream: add `highWaterMark` to the `map` and `filter` operator (#49249)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     rluvaton:add-stream-map-pool -> nodejs:main
Labels     stream, needs-ci
Commits    10
 - stream: add `highWaterMark` for the map operator
 - stream: update test to check output order
 - stream: update and rename
 - stream: filter empty in the right place
 - stream: remove unnecessary code
 - stream: allow user to pass `highWaterMark` to `map` and `filter` fns
 - stream: update docs after adding `highWaterMark`
 - stream: fix highWaterMark validation and fix test
 - stream: updated CR
 - stream: fix concurrency and test
Committers 1
 - Raz Luvaton <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/49249
Fixes: https://github.com/nodejs/node/issues/46132
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Robert Nagy 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49249
Fixes: https://github.com/nodejs/node/issues/46132
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Robert Nagy 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 19 Aug 2023 23:11:27 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49249#pullrequestreview-1592477937
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49249#pullrequestreview-1593092273
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/49249#pullrequestreview-1593077530
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-08-24T09:20:44Z: https://ci.nodejs.org/job/node-test-pull-request/53539/
- Querying data for job/node-test-pull-request/53539/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49249
From https://github.com/nodejs/node
 * branch                  refs/pull/49249/merge -> FETCH_HEAD
✔  Fetched commits as da197d189021..4b0707997951
--------------------------------------------------------------------------------
[main 0034c0e5f8] stream: add `highWaterMark` for the map operator
 Author: Raz Luvaton <[email protected]>
 Date: Sun Aug 20 01:42:56 2023 +0300
 2 files changed, 159 insertions(+), 17 deletions(-)
[main d02a503624] stream: update test to check output order
 Author: Raz Luvaton <[email protected]>
 Date: Wed Aug 23 18:14:20 2023 +0300
 1 file changed, 6 insertions(+), 3 deletions(-)
[main d41d4506f7] stream: update and rename
 Author: Raz Luvaton <[email protected]>
 Date: Wed Aug 23 18:16:36 2023 +0300
 1 file changed, 8 insertions(+), 12 deletions(-)
[main 281e41769b] stream: filter empty in the right place
 Author: Raz Luvaton <[email protected]>
 Date: Wed Aug 23 21:46:58 2023 +0300
 1 file changed, 5 insertions(+), 4 deletions(-)
[main bd13b8d45a] stream: remove unnecessary code
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 00:16:31 2023 +0300
 1 file changed, 2 insertions(+), 3 deletions(-)
[main 1e131966c9] stream: allow user to pass `highWaterMark` to `map` and `filter` fns
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 00:31:55 2023 +0300
 2 files changed, 60 insertions(+), 5 deletions(-)
Auto-merging doc/api/stream.md
[main 0b8bc71a8c] stream: update docs after adding `highWaterMark`
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 00:43:55 2023 +0300
 1 file changed, 12 insertions(+)
[main d2d8025628] stream: fix highWaterMark validation and fix test
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 10:38:54 2023 +0300
 3 files changed, 6 insertions(+), 3 deletions(-)
[main d78a1158ee] stream: updated CR
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 10:57:31 2023 +0300
 1 file changed, 4 insertions(+), 4 deletions(-)
[main 89215b6aa9] stream: fix concurrency and test
 Author: Raz Luvaton <[email protected]>
 Date: Thu Aug 24 11:22:42 2023 +0300
 2 files changed, 13 insertions(+), 14 deletions(-)
   ✔  Patches applied
There are 10 commits in the PR. Attempting autorebase.
Rebasing (2/20)
Executing: git node land --amend --yes

⚠  Found Fixes: #46132, skipping..

--------------------------------- New Message ----------------------------------

stream: add highWaterMark for the map operator
this is done so we don't wait for the first items to

finish before starting new ones
Fixes: #46132
Co-authored-by: Robert Nagy [email protected]

PR-URL: #49249

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD f4f887d5d4] stream: add highWaterMark for the map operator

Author: Raz Luvaton [email protected]

Date: Sun Aug 20 01:42:56 2023 +0300

2 files changed, 159 insertions(+), 17 deletions(-)

Rebasing (3/20)

Rebasing (4/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: update test to check output order
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 2f56951a72] stream: update test to check output order

Author: Raz Luvaton [email protected]

Date: Wed Aug 23 18:14:20 2023 +0300

1 file changed, 6 insertions(+), 3 deletions(-)

Rebasing (5/20)

Rebasing (6/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: update and rename
Co-authored-by: Robert Nagy [email protected]

PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD e26f66c2d2] stream: update and rename

Author: Raz Luvaton [email protected]

Date: Wed Aug 23 18:16:36 2023 +0300

1 file changed, 8 insertions(+), 12 deletions(-)

Rebasing (7/20)

Rebasing (8/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: filter empty in the right place
Co-authored-by: Robert Nagy [email protected]

PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 4b217f84c3] stream: filter empty in the right place

Author: Raz Luvaton [email protected]

Date: Wed Aug 23 21:46:58 2023 +0300

1 file changed, 5 insertions(+), 4 deletions(-)

Rebasing (9/20)

Rebasing (10/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: remove unnecessary code
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 0ef1dd9fd8] stream: remove unnecessary code

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 00:16:31 2023 +0300

1 file changed, 2 insertions(+), 3 deletions(-)

Rebasing (11/20)

Rebasing (12/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: allow user to pass highWaterMark to map and filter fns
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 8ae76c2f26] stream: allow user to pass highWaterMark to map and filter fns

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 00:31:55 2023 +0300

2 files changed, 60 insertions(+), 5 deletions(-)

Rebasing (13/20)

Rebasing (14/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: update docs after adding highWaterMark
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 6144fefb84] stream: update docs after adding highWaterMark

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 00:43:55 2023 +0300

1 file changed, 12 insertions(+)

Rebasing (15/20)

Rebasing (16/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: fix highWaterMark validation and fix test
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD b3ffbe89bf] stream: fix highWaterMark validation and fix test

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 10:38:54 2023 +0300

3 files changed, 6 insertions(+), 3 deletions(-)

Rebasing (17/20)

Rebasing (18/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: updated CR
Co-authored-by: Robert Nagy [email protected]

PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 59b5946dc1] stream: updated CR

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 10:57:31 2023 +0300

1 file changed, 4 insertions(+), 4 deletions(-)

Rebasing (19/20)

Rebasing (20/20)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: fix concurrency and test
PR-URL: #49249

Fixes: #46132

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Robert Nagy [email protected]
[detached HEAD 4dac50fa78] stream: fix concurrency and test

Author: Raz Luvaton [email protected]

Date: Thu Aug 24 11:22:42 2023 +0300

2 files changed, 13 insertions(+), 14 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.