GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add signature for `module.register` by GeoffreyBooth · Pull Request #49251 · nodejs/node

Conversation

@GeoffreyBooth

@GeoffreyBooth GeoffreyBooth commented Aug 20, 2023

Copy link
Copy Markdown
Member

In the recent PRs that created register, we neglected to define its signature. @nodejs/loaders

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to Node.js documentation. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders. labels Aug 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Aug 20, 2023
@GeoffreyBooth
GeoffreyBooth force-pushed the register-docs branch from 80a1649 to a3f9fc7 Compare August 20, 2023 00:06
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth
GeoffreyBooth force-pushed the register-docs branch 2 times, most recently from 912b03f to 5ec4fd3 Compare August 20, 2023 00:23
@GeoffreyBooth
GeoffreyBooth requested a review from aduh95 August 20, 2023 00:26
@GeoffreyBooth GeoffreyBooth added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 20, 2023
@github-actions

github-actions Bot commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.
anonrig and JakobJingleheimer reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 20, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53452/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth
GeoffreyBooth force-pushed the register-docs branch from 5ec4fd3 to a48dffc Compare August 20, 2023 02:39
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53455/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53459/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

The commit message subsystem should be doc:, not module:. Also FYI there is no need to run Jenkins CI for doc PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JakobJingleheimer
JakobJingleheimer approved these changes Aug 20, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth changed the title module: add docs signature for register doc: add signature for module.register Aug 20, 2023
@GeoffreyBooth
GeoffreyBooth force-pushed the register-docs branch from a48dffc to 76c719d Compare August 20, 2023 16:09
aduh95
aduh95 approved these changes Aug 20, 2023
View reviewed changes
@GeoffreyBooth
doc: add signature for module.register
367861e
@GeoffreyBooth
GeoffreyBooth force-pushed the register-docs branch from 76c719d to 367861e Compare August 20, 2023 16:19
aduh95
aduh95 approved these changes Aug 20, 2023
View reviewed changes
anonrig
anonrig approved these changes Aug 20, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 484ad83 into nodejs:main Aug 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 484ad83
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth
GeoffreyBooth deleted the register-docs branch August 20, 2023 20:55
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@GeoffreyBooth @UlisesGascon
doc: add signature for module.register
1704f24 
PR-URL: #49251
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth @targos
doc: add signature for module.register
0b72534 
PR-URL: nodejs#49251
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed
@targos targos added the backported-to-v18.x label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@GeoffreyBooth @targos
doc: add signature for module.register
258df0e 
PR-URL: #49251
Backport-PR-URL: #50669
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add signature for module.register
b27eef3 
PR-URL: nodejs/node#49251
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add signature for module.register
3ef713f 
PR-URL: nodejs/node#49251
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@anonrig anonrig anonrig approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. loaders Issues and PRs related to ES module loaders. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@GeoffreyBooth @nodejs-github-bot @aduh95 @ljharb @anonrig @JakobJingleheimer @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.