GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update description of `percent_encode` set in `WHATWG API` by pluris · Pull Request #49258 · nodejs/node

Conversation

@pluris

@pluris pluris commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

The character code is shown in the description of percent-encoded-bytes in the WHATWG URL Spec.
I think it would be better for readability to show the 'character code' the same as the WHATWG URL.

Refs: https://url.spec.whatwg.org/#percent-encoded-bytes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pluris
doc: update description for percent_encode sets in WHATWG API
cbbb920
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module. labels Aug 20, 2023
@daeyeon

daeyeon commented Aug 22, 2023

Copy link
Copy Markdown
Member

Please fix the markdown lint error. make lint-md can check it locally.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pluris
fixup! doc: update description of percent_encode set in WHATWG API
9f76526
@pluris

pluris commented Aug 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@daeyeon Hi, Thank you for your comment. I fixed it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon
daeyeon approved these changes Aug 22, 2023
View reviewed changes
@daeyeon daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 22, 2023
lpinca
lpinca approved these changes Aug 22, 2023
View reviewed changes
@daeyeon daeyeon added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 56a2a2e into nodejs:main Aug 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 56a2a2e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pluris
pluris deleted the doc/readablity_url branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Jungku Lee @UlisesGascon
doc: update description for percent_encode sets in WHATWG API
7428ebf 
PR-URL: #49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
Jungku Lee @targos
doc: update description for percent_encode sets in WHATWG API
c70945d 
PR-URL: #49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: update description for percent_encode sets in `WHATWG
6fc149c 
PR-URL: nodejs/node#49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: update description for percent_encode sets in `WHATWG
3e0d740 
PR-URL: nodejs/node#49258
Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pluris @daeyeon @nodejs-github-bot @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.