GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: add symlink to `compile_commands.json` file if needed by juanarbol · Pull Request #49260 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Aug 20, 2023

Copy link
Copy Markdown
Member

Usually lsp servers needs the compile_commands.json file in the root directory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@juanarbol
build: add symlink to compile_commands.json file if needed
c2590f5 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <[email protected]>
@juanarbol
juanarbol requested a review from RafaelGSS August 20, 2023 19:35
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Aug 20, 2023
@juanarbol

juanarbol commented Aug 20, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/build-files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Aug 21, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53487/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 22, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 23, 2023
CI Reliability 2023-08-23 nodejs/reliability#643
Open
27 tasks
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53535/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 24, 2023
CI Reliability 2023-08-24 nodejs/reliability#644
Open
27 tasks
@juanarbol juanarbol added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5ff1ead into nodejs:main Aug 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5ff1ead
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 25, 2023
CI Reliability 2023-08-25 nodejs/reliability#645
Open
CI Reliability 2023-08-26 nodejs/reliability#646
Open
CI Reliability 2023-08-27 nodejs/reliability#647
Open
CI Reliability 2023-08-28 nodejs/reliability#648
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@juanarbol @UlisesGascon
build: add symlink to compile_commands.json file if needed
cade571 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #49260
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@juanarbol @targos
build: add symlink to compile_commands.json file if needed
075c57e 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #49260
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@juanarbol
juanarbol deleted the juan/add-symlink-lsp branch December 6, 2023 03:27
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: add symlink to compile_commands.json file if needed
c5a7780 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: nodejs/node#49260
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: add symlink to compile_commands.json file if needed
1519d13 
Usually lsp servers needs the `compile_commands.json` file in the root
directory.

Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: nodejs/node#49260
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@juanarbol @nodejs-github-bot @anonrig @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.