GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in `stream.finished` documentation by aduh95 · Pull Request #49271 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

The colon is quite confusing as it implies the content after that section would be related, but in fact it has nothing to do with the callback version.

Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
doc: fix typo in stream.finished documentation
20abc75
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels Aug 21, 2023
lpinca
lpinca approved these changes Aug 21, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2023
trivikr
trivikr approved these changes Aug 22, 2023
View reviewed changes
Ayase-252
Ayase-252 approved these changes Aug 23, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e74d1b8 into nodejs:main Aug 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in e74d1b8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
aduh95 deleted the stream-finished-colon branch August 23, 2023 09:23
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@aduh95 @UlisesGascon
doc: fix typo in stream.finished documentation
ac3b884
PR-URL: #49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@aduh95 @targos
doc: fix typo in stream.finished documentation
f181c37
PR-URL: #49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix typo in stream.finished documentation
dc5da12
PR-URL: nodejs/node#49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix typo in stream.finished documentation
a1fb4eb
PR-URL: nodejs/node#49271
Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @lpinca @Ayase-252 @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.