GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: make test-worker-prof more robust by joyeecheung · Pull Request #49274 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Aug 21, 2023

Copy link
Copy Markdown
Member

Use a JS workload instead of repeating FS operations to make it less flaky on machines with little resources.
Refs: #26401
Refs: nodejs/reliability#640

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
joyeecheung marked this pull request as ready for review August 21, 2023 17:01
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 21, 2023
@joyeecheung
joyeecheung force-pushed the worker-prof-test branch from 097acb3 to c5d821d Compare August 21, 2023 17:03
@joyeecheung

joyeecheung commented Aug 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Stress test on Windows 2022 + VS 2019 https://ci.nodejs.org/job/node-stress-single-test/418/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53492/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung
joyeecheung force-pushed the worker-prof-test branch from c5d821d to d966328 Compare August 22, 2023 17:12
@joyeecheung

joyeecheung commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

Looks like it can still be flaky with the current workload. Switching to a time-based workload...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53498/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 23, 2023
CI Reliability 2023-08-23 nodejs/reliability#643
Open
27 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53517/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Aug 23, 2023

Copy link
Copy Markdown
Member Author

Another stress test on more platforms: https://ci.nodejs.org/job/node-stress-single-test/420/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 24, 2023
CI Reliability 2023-08-24 nodejs/reliability#644
Open
CI Reliability 2023-08-25 nodejs/reliability#645
Open
@joyeecheung

joyeecheung commented Aug 25, 2023

Copy link
Copy Markdown
Member Author

Updated the workload a bit, this seems to guarantee ~1000 ticks on both the parent and the worker.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung
joyeecheung force-pushed the worker-prof-test branch from 7779fab to 5c66341 Compare August 25, 2023 10:26
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53554/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Aug 25, 2023

Copy link
Copy Markdown
Member Author

Another stress test: https://ci.nodejs.org/job/node-stress-single-test/422/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 26, 2023
CI Reliability 2023-08-26 nodejs/reliability#646
Open
CI Reliability 2023-08-27 nodejs/reliability#647
Open
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53581/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53584/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 28, 2023
CI Reliability 2023-08-28 nodejs/reliability#648
Open
25 tasks
@joyeecheung
test: make test-worker-prof more robust
0d3a6f2 
Use a JS workload instead of repeating FS operations and use a
timer to make it less flaky on machines with little resources.
@joyeecheung
joyeecheung force-pushed the worker-prof-test branch from 5c66341 to 0d3a6f2 Compare August 28, 2023 08:15
@joyeecheung

joyeecheung commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Looks like the CI is having trouble rebasing the PR. Manually rebased instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53588/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 29, 2023
CI Reliability 2023-08-29 nodejs/reliability#649
Open
CI Reliability 2023-08-30 nodejs/reliability#650
Open
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53655/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 31, 2023
CI Reliability 2023-08-31 nodejs/reliability#651
Open
18 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53659/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 1, 2023
CI Reliability 2023-09-01 nodejs/reliability#652
Open
20 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53679/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 2, 2023
CI Reliability 2023-09-02 nodejs/reliability#653
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53695/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 3, 2023
CI Reliability 2023-09-03 nodejs/reliability#654
Open
CI Reliability 2023-09-04 nodejs/reliability#655
Open
benjamingr
benjamingr approved these changes Sep 4, 2023
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7f001c2 into nodejs:main Sep 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7f001c2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 5, 2023
CI Reliability 2023-09-05 nodejs/reliability#656
Open
CI Reliability 2023-09-06 nodejs/reliability#657
Open
CI Reliability 2023-09-07 nodejs/reliability#658
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
test: make test-worker-prof more robust
c3c6c4f 
Use a JS workload instead of repeating FS operations and use a
timer to make it less flaky on machines with little resources.

PR-URL: #49274
Refs: #26401
Refs: nodejs/reliability#640
Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@joyeecheung @nodejs-github-bot @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.