GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bootstrap: only use the isolate snapshot when compiling code cache by joyeecheung · Pull Request #49288 · nodejs/node

Conversation

joyeecheung commented Aug 22, 2023

Copy link

Copy Markdown

Member

We do not actually need to deserialize the context and the whole environment to compile the code cache, since code cache are not context-dependent anyway, deserializing just the isolate snapshot is enough.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          bootstrap: only use the isolate snapshot when compiling code cache

4a81b6b

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

joyeecheung marked this pull request as ready for review

August 22, 2023 17:28

nodejs-github-bot commented Aug 22, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/startup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 22, 2023

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Aug 22, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 22, 2023

nodejs-github-bot commented Aug 22, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53499/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Aug 23, 2023

CI Reliability 2023-08-23 nodejs/reliability#643

Open

27 tasks

legendecas approved these changes

Aug 23, 2023

View reviewed changes

This was referenced Aug 24, 2023

CI Reliability 2023-08-24 nodejs/reliability#644

Open

CI Reliability 2023-08-25 nodejs/reliability#645

Open

CI Reliability 2023-08-26 nodejs/reliability#646

Open

CI Reliability 2023-08-27 nodejs/reliability#647

Open

CI Reliability 2023-08-28 nodejs/reliability#648

Open

CI Reliability 2023-08-29 nodejs/reliability#649

Open

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 30, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 30, 2023

nodejs-github-bot commented Aug 30, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53653/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label

Aug 31, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Aug 31, 2023

nodejs-github-bot commented Aug 31, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/49288
✔  Done loading data for nodejs/node/pull/49288
----------------------------------- PR info ------------------------------------
Title      bootstrap: only use the isolate snapshot when compiling code cache (#49288)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:isolate-code-cache -> nodejs:main
Labels     c++, needs-ci
Commits    1
 - bootstrap: only use the isolate snapshot when compiling code cache
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 22 Aug 2023 17:28:31 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-08-30T21:57:54Z: https://ci.nodejs.org/job/node-test-pull-request/53653/
- Querying data for job/node-test-pull-request/53653/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6035126866

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Aug 31, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 31, 2023

nodejs-github-bot commented Aug 31, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53664/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 1, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53680/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Sep 2, 2023

CI Reliability 2023-09-02 nodejs/reliability#653

Open

22 tasks

nodejs-github-bot commented Sep 2, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53696/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Sep 3, 2023

CI Reliability 2023-09-03 nodejs/reliability#654

Open

CI Reliability 2023-09-04 nodejs/reliability#655

Open

joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 4, 2023

nodejs-github-bot commented Sep 4, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/49288
✔  Done loading data for nodejs/node/pull/49288
----------------------------------- PR info ------------------------------------
Title      bootstrap: only use the isolate snapshot when compiling code cache (#49288)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:isolate-code-cache -> nodejs:main
Labels     c++, needs-ci
Commits    1
 - bootstrap: only use the isolate snapshot when compiling code cache
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 22 Aug 2023 17:28:31 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-02T20:14:04Z: https://ci.nodejs.org/job/node-test-pull-request/53696/
- Querying data for job/node-test-pull-request/53696/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6075654085

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Sep 4, 2023

nodejs-github-bot commented Sep 4, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/49288
✔  Done loading data for nodejs/node/pull/49288
----------------------------------- PR info ------------------------------------
Title      bootstrap: only use the isolate snapshot when compiling code cache (#49288)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:isolate-code-cache -> nodejs:main
Labels     c++, needs-ci
Commits    1
 - bootstrap: only use the isolate snapshot when compiling code cache
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 22 Aug 2023 17:28:31 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/49288#pullrequestreview-1590612969
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-04T16:08:03Z: https://ci.nodejs.org/job/node-test-pull-request/53696/
- Querying data for job/node-test-pull-request/53696/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6077625182

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member Author

Somehow the GitHub UI says "All checks have passed" and node-core-utils still complains about it...perhaps something is wrong the the GitHub API result, landing it manually.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added a commit that referenced this pull request

Sep 4, 2023


          bootstrap: only use the isolate snapshot when compiling code cache

4d0f930

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: #49288
Reviewed-By: Chengzhong Wu <[email protected]>

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member Author

Landed in 4d0f930

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung closed this

Sep 4, 2023

This was referenced Sep 5, 2023

CI Reliability 2023-09-05 nodejs/reliability#656

Open

CI Reliability 2023-09-06 nodejs/reliability#657

Open

CI Reliability 2023-09-07 nodejs/reliability#658

Open

ruyadorno pushed a commit that referenced this pull request

Sep 28, 2023


          bootstrap: only use the isolate snapshot when compiling code cache

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: #49288
Reviewed-By: Chengzhong Wu <[email protected]>

This was referenced Sep 28, 2023

v20.7.1 proposal #49917

Closed

v20.8.0 proposal #49932

Merged

Reviewers

legendecas

legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.