GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update fs doc for filter by shubham9411 · Pull Request #49289 · nodejs/node

Conversation

@shubham9411

@shubham9411 shubham9411 commented Aug 22, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Updating doc for fs.cp, fsPromises.cp and fs.cpSync.

Added the caveat that filter will be applied to both files and dirs.

Fixes: #49092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module. labels Aug 22, 2023
@shubham9411 shubham9411 mentioned this pull request Aug 22, 2023
"Experimental" fs.cp(), fs.cpSync(), fsPromises.cp() methods don't handle recursion when there is a filter #49092
Closed
tniessen
tniessen reviewed Aug 22, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems extremely long and verbose for a rather simple statement. The documentation already says that the function will be applied to files and directories.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Aug 23, 2023
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 23, 2023
tniessen
tniessen approved these changes Aug 23, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: commit message does not adhere to the commit message guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shubham9411 added 2 commits August 23, 2023 18:59
@shubham9411
doc: updating doc for fs.cp, fsPromises.cp and fs.cpSync
fa10461
@shubham9411
maing the statement simpler
7898fe0
@shubham9411
shubham9411 force-pushed the updating-fs-filter-doc branch from 7a4107b to 7898fe0 Compare August 23, 2023 13:31
aymen94
aymen94 approved these changes Aug 23, 2023
View reviewed changes
lpinca
lpinca approved these changes Aug 23, 2023
View reviewed changes
LiviaMedeiros
LiviaMedeiros approved these changes Aug 24, 2023
View reviewed changes
@LiviaMedeiros

LiviaMedeiros commented Aug 24, 2023

Copy link
Copy Markdown
Member

The commit message guidelines suggest that it should start with an imperative verb, so maybe something like

doc: update doc for fs.cp, fsPromises.cp and fs.cpSync

or

doc: update options.filter description for fs.cp

Would be slightly better.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shubham9411

shubham9411 commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

@LiviaMedeiros yes, I had updated first commit to
doc: update doc for fs.cp, fsPromises.cp and fs.cpSync
😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 4178683 into nodejs:main Aug 26, 2023
@aduh95

aduh95 commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

Landed in 4178683, thanks for the contribution :)
shubham9411 reacted with hooray emoji shubham9411 reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@shubham9411 @UlisesGascon
doc: update options.filter description for fs.cp
7c0cd2f 
PR-URL: #49289
Fixes: #49092
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@shubham9411 @targos
doc: update options.filter description for fs.cp
0dda724 
PR-URL: #49289
Fixes: #49092
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: update options.filter description for fs.cp
7e5adf2 
PR-URL: nodejs/node#49289
Fixes: nodejs/node#49092
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: update options.filter description for fs.cp
4ea512a 
PR-URL: nodejs/node#49289
Fixes: nodejs/node#49092
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@coderabbitai coderabbitai Bot mentioned this pull request Jul 29, 2026
perf(build): use node:fs for cache checks netlify/build#7107
Merged
3 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Experimental" fs.cp(), fs.cpSync(), fsPromises.cp() methods don't handle recursion when there is a filter

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@shubham9411 @LiviaMedeiros @aduh95 @lpinca @tniessen @aymen94 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.