GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: remove redundant code in readableWebStream() by deokjinkim · Pull Request #49298 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Aug 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove redundant code by moving it to outside of if/else. Plus, make options optional in doc.

Below code is duplicated because it exists on both if and else.

    const {
      readableStreamCancel,
    } = require('internal/webstreams/readablestream');
    this[kRef]();
    this.once('close', () => {
      readableStreamCancel(readable);
    });

And options param is optional like below.

  /**
   * @typedef {import('../webstreams/readablestream').ReadableStream
   * } ReadableStream
   * @param {{
   *   type?: string;
   *   }} [options]
   * @returns {ReadableStream}
   */
  readableWebStream(options = kEmptyObject) {

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illusi0n7, bricss, and debadree25 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@deokjinkim
fs: remove redundant code in readableWebStream()
f1af222 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 23, 2023
@deokjinkim
deokjinkim requested a review from debadree25 August 24, 2023 12:51
debadree25
debadree25 approved these changes Aug 24, 2023
View reviewed changes

@debadree25 debadree25 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deokjinkim reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53541/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 24, 2023
View reviewed changes
@deokjinkim deokjinkim added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c5cad08 into nodejs:main Aug 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in c5cad08
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@deokjinkim @UlisesGascon
fs: remove redundant code in readableWebStream()
92772a8 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: #49298
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@deokjinkim @targos
fs: remove redundant code in readableWebStream()
69b7f91 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: #49298
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: remove redundant code in readableWebStream()
e831d65 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: nodejs/node#49298
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: remove redundant code in readableWebStream()
bad1468 
Remove redundant code by moving it to outside of `if/else`. Plus,
make `options` optional in doc.

PR-URL: nodejs/node#49298
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@deokjinkim @nodejs-github-bot @lpinca @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.