GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: add --write-snapshot-as-array-literals to configure.py by joyeecheung · Pull Request #49312 · nodejs/node

Conversation

joyeecheung commented Aug 24, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This makes it easier to locate indeterminism in the snapshot, with the following command:

$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc

Refs: nodejs/build#3043

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          build: add --write-snapshot-as-array-literals to configure.py

0e921f5

This makes it easier to locate indeterminism in the snapshot, with
the following command:

$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc

joyeecheung marked this pull request as ready for review

August 24, 2023 16:37

nodejs-github-bot commented Aug 24, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/gyp
@nodejs/startup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Aug 24, 2023

joyeecheung mentioned this pull request

Aug 24, 2023

Reproducible builds on Linux nodejs/build#3043

Closed

bnoordhuis approved these changes

Aug 25, 2023

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 31, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 31, 2023

nodejs-github-bot commented Aug 31, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53663/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Sep 1, 2023

CI Reliability 2023-09-01 nodejs/reliability#652

Open

20 tasks

nodejs-github-bot commented Sep 1, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53681/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Sep 2, 2023

CI Reliability 2023-09-02 nodejs/reliability#653

Open

22 tasks

joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 2, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 2, 2023

nodejs-github-bot commented Sep 2, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/49312
✔  Done loading data for nodejs/node/pull/49312
----------------------------------- PR info ------------------------------------
Title      build: add --write-snapshot-as-array-literals to configure.py (#49312)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:config-array-literals -> nodejs:main
Labels     lib / src, needs-ci
Commits    1
 - build: add --write-snapshot-as-array-literals to configure.py
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49312
Refs: https://github.com/nodejs/build/issues/3043
Reviewed-By: Ben Noordhuis 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49312
Refs: https://github.com/nodejs/build/issues/3043
Reviewed-By: Ben Noordhuis 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 24 Aug 2023 16:37:26 GMT
   ✔  Approvals: 1
   ✔  - Ben Noordhuis (@bnoordhuis) (TSC): https://github.com/nodejs/node/pull/49312#pullrequestreview-1595533008
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-01T19:44:30Z: https://ci.nodejs.org/job/node-test-pull-request/53681/
- Querying data for job/node-test-pull-request/53681/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6060350802

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Sep 2, 2023

This was referenced Sep 3, 2023

CI Reliability 2023-09-03 nodejs/reliability#654

Open

CI Reliability 2023-09-04 nodejs/reliability#655

Open

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member Author

Somehow the GitHub UI says "All checks have passed" and node-core-utils still complains about it...perhaps something is wrong the the GitHub API result, landing it manually.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added a commit that referenced this pull request

Sep 4, 2023


          build: add --write-snapshot-as-array-literals to configure.py

0028fd1

This makes it easier to locate indeterminism in the snapshot, with
the following command:

$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc

PR-URL: #49312
Refs: nodejs/build#3043
Reviewed-By: Ben Noordhuis <[email protected]>

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member Author

Landed in 0028fd1

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung closed this

Sep 4, 2023

This was referenced Sep 5, 2023

CI Reliability 2023-09-05 nodejs/reliability#656

Open

CI Reliability 2023-09-06 nodejs/reliability#657

Open

ruyadorno pushed a commit that referenced this pull request

Sep 28, 2023


          build: add --write-snapshot-as-array-literals to configure.py

31db0b8

This makes it easier to locate indeterminism in the snapshot, with
the following command:

$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc

PR-URL: #49312
Refs: nodejs/build#3043
Reviewed-By: Ben Noordhuis <[email protected]>

This was referenced Sep 28, 2023

v20.7.1 proposal #49917

Closed

v20.8.0 proposal #49932

Merged

Reviewers

bnoordhuis

bnoordhuis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joyeecheung commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 24, 2023

Uh oh!

nodejs-github-bot commented Aug 31, 2023

Uh oh!

nodejs-github-bot commented Sep 1, 2023

Uh oh!

nodejs-github-bot commented Sep 2, 2023

Uh oh!

joyeecheung commented Sep 4, 2023

Uh oh!

joyeecheung commented Sep 4, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joyeecheung commented Aug 24, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.