GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: rename test-crypto-modp1-error by tniessen · Pull Request #49348 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Aug 27, 2023

Copy link
Copy Markdown
Member

This test is not specific to 'modp1' at all, it might as well use any of the other groups.

Refs: #40451

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
test: rename test-crypto-modp1-error
6cb39af 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs#40451
@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 27, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 27, 2023
panva
panva approved these changes Aug 28, 2023
View reviewed changes
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen

tniessen commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

CI infra is broken, see nodejs/build#3475.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 28, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 29, 2023
CI Reliability 2023-08-29 nodejs/reliability#649
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53612/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 452bae1 into nodejs:main Aug 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 452bae1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 30, 2023
CI Reliability 2023-08-30 nodejs/reliability#650
Open
CI Reliability 2023-08-31 nodejs/reliability#651
Open
CI Reliability 2023-09-01 nodejs/reliability#652
Open
CI Reliability 2023-09-02 nodejs/reliability#653
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
test: rename test-crypto-modp1-error
0d23c1d 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@tniessen @targos
test: rename test-crypto-modp1-error
5f1a1ae 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: rename test-crypto-modp1-error
3dcdcbe 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: rename test-crypto-modp1-error
5052427 
This test is not specific to modp1 at all, it might as well use any of
the other groups.

Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tniessen @nodejs-github-bot @panva @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.