GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: remove modules team from CODEOWNERS by benjamingr · Pull Request #49412 · nodejs/node

Conversation

@benjamingr

@benjamingr benjamingr commented Aug 30, 2023

Copy link
Copy Markdown
Member

Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas.

cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr benjamingr added the meta Issues and PRs related to the general management of the project. label Aug 30, 2023
richardlau
richardlau reviewed Aug 30, 2023
View reviewed changes
Comment thread .github/CODEOWNERS Resolved

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Aug 30, 2023
View reviewed changes
richardlau
richardlau approved these changes Aug 30, 2023
View reviewed changes
@ljharb

ljharb commented Aug 30, 2023

Copy link
Copy Markdown
Member

The modules team is inactive but we very much use the github team for notifications; I can be added to the loaders team but i usually don't want those notifications.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Aug 30, 2023
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Aug 30, 2023
View reviewed changes
lpinca
lpinca approved these changes Aug 31, 2023
View reviewed changes
JakobJingleheimer
JakobJingleheimer approved these changes Sep 1, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49412
✔  Done loading data for nodejs/node/pull/49412
----------------------------------- PR info ------------------------------------
Title      meta: remove modules team from CODEOWNERS (#49412)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:benjamingr-patch-1 -> nodejs:main
Labels     meta
Commits    1
 - meta: remove modules team from CODEOWNERS
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49412
Reviewed-By: Geoffrey Booth 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49412
Reviewed-By: Geoffrey Booth 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 30 Aug 2023 16:31:29 GMT
   ✔  Approvals: 6
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111038
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111317
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603163118
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603483216
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49412#pullrequestreview-1605620553
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49412#pullrequestreview-1607301198
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6052223823
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 1, 2023
@benjamingr @GeoffreyBooth
meta: remove modules team from CODEOWNERS
14929d6 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.
@GeoffreyBooth
GeoffreyBooth force-pushed the benjamingr-patch-1 branch from 6d33054 to 14929d6 Compare September 1, 2023 18:40
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 1, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49412
✔  Done loading data for nodejs/node/pull/49412
----------------------------------- PR info ------------------------------------
Title      meta: remove modules team from CODEOWNERS (#49412)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:benjamingr-patch-1 -> nodejs:main
Labels     meta
Commits    1
 - meta: remove modules team from CODEOWNERS
Committers 1
 - Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/49412
Reviewed-By: Geoffrey Booth 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49412
Reviewed-By: Geoffrey Booth 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - meta: remove modules team from CODEOWNERS
   ℹ  This PR was created on Wed, 30 Aug 2023 16:31:29 GMT
   ✔  Approvals: 6
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111038
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111317
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603163118
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603483216
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49412#pullrequestreview-1605620553
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49412#pullrequestreview-1607301198
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6052969025
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Sep 1, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 12ee988 into main Sep 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 12ee988
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the benjamingr-patch-1 branch September 1, 2023 20:28
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@benjamingr @UlisesGascon
meta: remove modules team from CODEOWNERS
83b7d3a 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.

PR-URL: #49412
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@benjamingr @targos
meta: remove modules team from CODEOWNERS
2827779 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.

PR-URL: #49412
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: remove modules team from CODEOWNERS
c49fe66 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.

PR-URL: nodejs/node#49412
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: remove modules team from CODEOWNERS
724beeb 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.

PR-URL: nodejs/node#49412
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@benjamingr @ljharb @nodejs-github-bot @GeoffreyBooth @lpinca @anonrig @JakobJingleheimer @richardlau @RafaelGSS @LiviaMedeiros
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.