GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: preserve original property descriptor when mutating objects by ErickWendel · Pull Request #49433 · nodejs/node

Conversation

@ErickWendel

@ErickWendel ErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
Member

In this comment, #49397 (comment) @ljharb suggested preserving the behavior and attributes of properties as they were before the modification

cc @nodejs/test_runner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023 •
edited by ErickWendel
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 1, 2023
@ErickWendel
test_runner: preserve original property descriptor
3fda352
@ErickWendel
ErickWendel force-pushed the test_runner/mock-preserve-original-property-descriptor branch from 768af5c to 3fda352 Compare September 1, 2023 17:15
ljharb
ljharb approved these changes Sep 1, 2023
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread lib/internal/test_runner/mock/mock_timers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ErickWendel ErickWendel self-assigned this Sep 1, 2023
@ErickWendel

ErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

Uh, good catch! Gonna do it in a few

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ErickWendel added 2 commits September 1, 2023 15:55
@ErickWendel
test_runner: add test for checking the property descriptor state
77caf13
Signed-off-by: Erick Wendel <[email protected]>
@ErickWendel
test_runner: refactoring functions
64f872a
Signed-off-by: Erick Wendel <[email protected]>
@ErickWendel
ErickWendel force-pushed the test_runner/mock-preserve-original-property-descriptor branch from 93a9e75 to 64f872a Compare September 1, 2023 19:02
@ErickWendel

ErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ljharb
ljharb approved these changes Sep 1, 2023
View reviewed changes

@ljharb ljharb left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is way cleaner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ErickWendel reacted with heart emoji
All reactions
  • ❤️ 1 reaction
benjamingr
benjamingr approved these changes Sep 2, 2023
View reviewed changes
@ErickWendel ErickWendel added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53689/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton
rluvaton approved these changes Sep 2, 2023
View reviewed changes
atlowChemi
atlowChemi approved these changes Sep 2, 2023
View reviewed changes
@atlowChemi atlowChemi added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53694/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Sep 3, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 3, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49433
✔  Done loading data for nodejs/node/pull/49433
----------------------------------- PR info ------------------------------------
Title      test_runner: preserve original property descriptor when mutating objects (#49433)
Author     Erick Wendel  (@ErickWendel)
Branch     ErickWendel:test_runner/mock-preserve-original-property-descriptor -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    3
 - test_runner: preserve original property descriptor
 - test_runner: add test for checking the property descriptor state
 - test_runner: refactoring functions
Committers 1
 - Erick Wendel 
PR-URL: https://github.com/nodejs/node/pull/49433
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
Reviewed-By: Chemi Atlow 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49433
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
Reviewed-By: Chemi Atlow 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 01 Sep 2023 17:13:36 GMT
   ✔  Approvals: 4
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608049890
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608346449
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608366919
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608411583
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-02T19:22:27Z: https://ci.nodejs.org/job/node-test-pull-request/53694/
- Querying data for job/node-test-pull-request/53694/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49433
From https://github.com/nodejs/node
 * branch                  refs/pull/49433/merge -> FETCH_HEAD
✔  Fetched commits as 0add7a8f0c92..64f872a28f86
--------------------------------------------------------------------------------
[main 9ce045d826] test_runner: preserve original property descriptor
 Author: Erick Wendel 
 Date: Fri Sep 1 14:07:12 2023 -0300
 1 file changed, 137 insertions(+), 35 deletions(-)
[main 9a7621b25c] test_runner: add test for checking the property descriptor state
 Author: Erick Wendel 
 Date: Fri Sep 1 15:55:26 2023 -0300
 1 file changed, 49 insertions(+)
[main 2de5750354] test_runner: refactoring functions
 Author: Erick Wendel 
 Date: Fri Sep 1 15:59:39 2023 -0300
 2 files changed, 162 insertions(+), 141 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test_runner: preserve original property descriptor

PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Raz Luvaton [email protected]
Reviewed-By: Chemi Atlow [email protected]
Reviewed-By: Moshe Atlow [email protected]

[detached HEAD dc9c314b0f] test_runner: preserve original property descriptor
Author: Erick Wendel [email protected]
Date: Fri Sep 1 14:07:12 2023 -0300
1 file changed, 137 insertions(+), 35 deletions(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test_runner: add test for checking the property descriptor state

Signed-off-by: Erick Wendel [email protected]
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Raz Luvaton [email protected]
Reviewed-By: Chemi Atlow [email protected]
Reviewed-By: Moshe Atlow [email protected]

[detached HEAD 496538d949] test_runner: add test for checking the property descriptor state
Author: Erick Wendel [email protected]
Date: Fri Sep 1 15:55:26 2023 -0300
1 file changed, 49 insertions(+)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test_runner: refactoring functions

Signed-off-by: Erick Wendel [email protected]
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Raz Luvaton [email protected]
Reviewed-By: Chemi Atlow [email protected]
Reviewed-By: Moshe Atlow [email protected]

[detached HEAD 1dc3702999] test_runner: refactoring functions
Author: Erick Wendel [email protected]
Date: Fri Sep 1 15:59:39 2023 -0300
2 files changed, 162 insertions(+), 141 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6065810018

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@atlowChemi atlowChemi added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e82cfc into nodejs:main Sep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e82cfc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@ErickWendel @UlisesGascon
test_runner: preserve original property descriptor
36763fa
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@ErickWendel @targos
test_runner: preserve original property descriptor
760c982
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: preserve original property descriptor
089971c
PR-URL: nodejs/node#49433
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: preserve original property descriptor
7613769
PR-URL: nodejs/node#49433
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes
@rluvaton rluvaton rluvaton approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ErickWendel ErickWendel

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ErickWendel @nodejs-github-bot @ljharb @benjamingr @MoLow @rluvaton @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.