GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: V8: cherry-pick b60a03df4ceb by joyeecheung · Pull Request #49491 · nodejs/node

Conversation

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member

Original commit message:

[api] mark v8::Script and v8::UnboundScript as v8::Data

v8::UnboundModuleScript and v8::Module are already v8::Data.
Mark v8::Script and v8::UnboundScript as v8::Data so that they
can be used in other V8 APIs that takes v8::Data.

Refs: https://github.com/nodejs/node/pull/48510

Bug: v8:14120
Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
Reviewed-by: Camillo Bruni <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Sep 4, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/gyp
@nodejs/v8-update

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added the dont-land-on-v20.x label

Sep 4, 2023

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v8 engine Issues and PRs related to the V8 dependency. labels

Sep 4, 2023

joyeecheung commented Sep 4, 2023

Copy link

Copy Markdown

Member Author

This can't land on v20.x for now because it can break the ABI - we could consider an exception if we think that the series of memory issues caused by the module/scripts should be fixed in the LTS given their impact. But before that we should wait until #48510 lands and gets released and tested in the wild to see if this is really necessary for 20.x.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5549/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5549/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53814/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5549/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5550/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5550/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5550/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig approved these changes

Sep 10, 2023

View reviewed changes

aymen94 approved these changes

Sep 11, 2023

View reviewed changes

joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 11, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 11, 2023

nodejs-github-bot commented Sep 11, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/49491
✔  Done loading data for nodejs/node/pull/49491
----------------------------------- PR info ------------------------------------
Title      deps: V8: cherry-pick b60a03df4ceb (#49491)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:backport-script -> nodejs:main
Labels     build, v8 engine, needs-ci, dont-land-on-v20.x
Commits    1
 - deps: V8: cherry-pick b60a03df4ceb
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49491
Refs: https://github.com/v8/v8/commit/b60a03df4cebafb4c92ee644d11617ad73889e5e
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49491
Refs: https://github.com/v8/v8/commit/b60a03df4cebafb4c92ee644d11617ad73889e5e
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 04 Sep 2023 21:11:57 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49491#pullrequestreview-1618824001
   ✘  This PR needs to wait 9 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-08T11:06:13Z: https://ci.nodejs.org/job/node-test-pull-request/53814/
- Querying data for job/node-test-pull-request/53814/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6145737064

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Sep 11, 2023

joyeecheung commented

Sep 11, 2023

View reviewed changes

Comment thread

common.gypi Resolved

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung force-pushed the backport-script branch from 1e8b945 to 1e3f814 Compare

September 11, 2023 11:40


          deps: V8: cherry-pick b60a03df4ceb

f4bc4f2

Original commit message:

    [api] mark v8::Script and v8::UnboundScript as v8::Data

    v8::UnboundModuleScript and v8::Module are already v8::Data.
    Mark v8::Script and v8::UnboundScript as v8::Data so that they
    can be used in other V8 APIs that takes v8::Data.

    Refs: nodejs#48510

    Bug: v8:14120
    Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
    Reviewed-by: Camillo Bruni <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d

joyeecheung force-pushed the backport-script branch from 134e75a to f4bc4f2 Compare

September 11, 2023 11:44

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 11, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 11, 2023

nodejs-github-bot commented Sep 11, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53888/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 11, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5555/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 11, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5555/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 11, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5555/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Linkgoron approved these changes

Sep 11, 2023

View reviewed changes

joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Sep 12, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 12, 2023

nodejs-github-bot merged commit 668437c into nodejs:main

Sep 12, 2023

nodejs-github-bot commented Sep 12, 2023

Copy link

Copy Markdown

Collaborator

Landed in 668437c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung mentioned this pull request

Sep 12, 2023

module: rework of memory management in vm APIs with the importModuleDynamically option #48510

Closed

joyeecheung added the dont-land-on-v18.x label

Sep 13, 2023

joyeecheung mentioned this pull request

Sep 15, 2023

deps: update V8 to 11.8 #49639

Closed

joyeecheung added a commit to joyeecheung/node that referenced this pull request

Sep 26, 2023


          deps: V8: cherry-pick b60a03df4ceb

bce8b0b

Original commit message:

    [api] mark v8::Script and v8::UnboundScript as v8::Data

    v8::UnboundModuleScript and v8::Module are already v8::Data.
    Mark v8::Script and v8::UnboundScript as v8::Data so that they
    can be used in other V8 APIs that takes v8::Data.

    Refs: nodejs#48510

    Bug: v8:14120
    Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
    Reviewed-by: Camillo Bruni <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d
PR-URL: nodejs#49491
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>

joyeecheung mentioned this pull request

Sep 26, 2023

[v20.x] backport vm-related memory fixes #49874

Closed

RafaelGSS mentioned this pull request

Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

Reviewers

anonrig

anonrig approved these changes

+2 more reviewers

Linkgoron

Linkgoron approved these changes

aymen94

aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.