GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — esm: remove return value for `Module.register` by aduh95 · Pull Request #49529 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Sep 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The current API shape is not great because it's too limited and redundant with the use of MessagePort.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji jlenon7 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction
@aduh95
esm: remove return value for Module.register
19cbaf1 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 7, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Sep 7, 2023
View reviewed changes
@aduh95
fixup! esm: remove return value for Module.register
22f5794
aduh95
aduh95 commented Sep 7, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
Update doc/api/module.md
3e8188b
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53782/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 7, 2023
test: increase coverage of Module.register and initialize hook #49532
Merged
GeoffreyBooth
GeoffreyBooth approved these changes Sep 7, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Sep 8, 2023
CI Reliability 2023-09-08 nodejs/reliability#659
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53808/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JakobJingleheimer
JakobJingleheimer approved these changes Sep 8, 2023
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b64c3ee into nodejs:main Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in b64c3ee
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the register-return-value branch September 9, 2023 21:58
@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
CI Reliability 2023-09-11 nodejs/reliability#662
Open
18 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
esm: remove return value for Module.register
be48267 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.

PR-URL: #49529
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: remove return value for Module.register
fbc7c3e 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.

PR-URL: nodejs#49529
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed
@targos targos added the backported-to-v18.x label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: remove return value for Module.register
4be5612 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.

PR-URL: #49529
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: remove return value for Module.register
3a289bf 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.

PR-URL: nodejs/node#49529
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: remove return value for Module.register
c8b196a 
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.

PR-URL: nodejs/node#49529
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.