GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: rename possibly confusing variable by aduh95 · Pull Request #49536 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

A "selector" usually refers to a CSS selector, when here it refers to a checkbox.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji jlenon7 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction
@aduh95
doc: rename possibly confusing variable
96aedb3 
A "selector" usually refers to a CSS selector, when here it refers to a
checkbox.
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/website
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 7, 2023
ovflowd
ovflowd approved these changes Sep 7, 2023
View reviewed changes
@ovflowd ovflowd added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 7, 2023
@github-actions

github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ovflowd. Please 👍 to approve.
atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 mentioned this pull request Sep 7, 2023
doc: toggle all flavor selectors sticky on click #49526
Merged
bnb
bnb approved these changes Sep 7, 2023
View reviewed changes
atlowChemi
atlowChemi approved these changes Sep 7, 2023
View reviewed changes
Comment thread doc/api_assets/api.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
fixup! doc: rename possibly confusing variable
5be6ca6
atlowChemi
atlowChemi approved these changes Sep 8, 2023
View reviewed changes

@atlowChemi atlowChemi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 8, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49536
✔  Done loading data for nodejs/node/pull/49536
----------------------------------- PR info ------------------------------------
Title      doc: rename possibly confusing variable (#49536)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:flavor-selector-toggle -> nodejs:main
Labels     doc, fast-track, author ready
Commits    2
 - doc: rename possibly confusing variable
 - fixup! doc: rename possibly confusing variable
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49536
Reviewed-By: Claudio Wunder 
Reviewed-By: Tierney Cyren 
Reviewed-By: Chemi Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49536
Reviewed-By: Claudio Wunder 
Reviewed-By: Tierney Cyren 
Reviewed-By: Chemi Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 07 Sep 2023 14:49:39 GMT
   ✔  Approvals: 3
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49536#pullrequestreview-1615635164
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/49536#pullrequestreview-1615729819
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49536#pullrequestreview-1617314184
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6122057730
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 8103a64 into nodejs:main Sep 8, 2023
@aduh95

aduh95 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

Landed in 8103a64
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the flavor-selector-toggle branch September 8, 2023 15:04
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
doc: rename possibly confusing variable and CSS class
8e033c3 
A "selector" usually refers to a CSS selector, when here it refers to a
checkbox.

PR-URL: #49536
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
aduh95 added a commit that referenced this pull request Feb 10, 2025
@aduh95
doc: rename possibly confusing variable and CSS class
d74cff7 
A "selector" usually refers to a CSS selector, when here it refers to a
checkbox.

PR-URL: #49536
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 18, 2025
2025-02-20, Version 18.20.7 'Hydrogen' (LTS) #57122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes
@ovflowd ovflowd ovflowd approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @bnb @ovflowd @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.