GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: support multiple `--env-file` declarations by anonrig · Pull Request #49542 · nodejs/node

Conversation

anonrig commented Sep 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

From now on, you can pass multiple --env-file arguments. Each valid config file will
override any pre-existing declarations made in previous config file.

Example:

node --env-file=.env --env-file=.development.env index.js

Ref: #49148

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, H4ad, bryan-hoang, raxityo, brett-onions, snewell92, and flipeador reacted with thumbs up emoji

furey, jvisker, and flipeador reacted with hooray emoji

bricss, furey, flipeador, and rodrigo98rm reacted with rocket emoji

All reactions

👍 7 reactions
🎉 3 reactions
🚀 4 reactions

nodejs-github-bot commented Sep 7, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/startup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Sep 7, 2023

anonrig mentioned this pull request

Sep 5, 2023

.env file support issue tracker #49148

Open

8 tasks done

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label

Sep 7, 2023

This comment was marked as resolved.

anonrig force-pushed the multiple-env-file branch from 79aad9c to efdc369 Compare

September 7, 2023 18:24

GeoffreyBooth reviewed

Sep 7, 2023

View reviewed changes

Comment thread

doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig force-pushed the multiple-env-file branch from efdc369 to 988b10f Compare

September 7, 2023 19:30

anonrig requested a review from GeoffreyBooth

September 7, 2023 19:33

atlowChemi reviewed

Sep 7, 2023

View reviewed changes

Comment thread

doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Sep 8, 2023

anonrig force-pushed the multiple-env-file branch from 988b10f to 237acae Compare

September 8, 2023 13:58


          src: support multiple --env-file declarations

3a8da52

anonrig force-pushed the multiple-env-file branch from 237acae to 3a8da52 Compare

September 8, 2023 13:58

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 8, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 8, 2023

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53816/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53823/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 8, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53825/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Sep 9, 2023

CI Reliability 2023-09-09 nodejs/reliability#660

Open

24 tasks

nodejs-github-bot commented Sep 9, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53846/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Sep 10, 2023

CI Reliability 2023-09-10 nodejs/reliability#661

Open

19 tasks

GeoffreyBooth approved these changes

Sep 10, 2023

View reviewed changes

anonrig added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

review wanted PRs that need review. labels

Sep 10, 2023

atlowChemi approved these changes

Sep 10, 2023

View reviewed changes

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 10, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 10, 2023

nodejs-github-bot merged commit ce30b4e into nodejs:main

Sep 10, 2023

nodejs-github-bot commented Sep 10, 2023

Copy link

Copy Markdown

Collaborator

Landed in ce30b4e

bricss reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss mentioned this pull request

Sep 10, 2023

v20.7.0 proposal #49592

Merged

github-actions Bot mentioned this pull request

Sep 11, 2023

CI Reliability 2023-09-11 nodejs/reliability#662

Open

18 tasks

UlisesGascon pushed a commit that referenced this pull request

Sep 11, 2023


          src: support multiple --env-file declarations

022f1b7

PR-URL: #49542
Refs: #49148
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

UlisesGascon added a commit that referenced this pull request

Sep 11, 2023


          2023-09-13, Version 20.7.0 (Current)

dcc3c41

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592

github-actions Bot mentioned this pull request

Sep 12, 2023

CI Reliability 2023-09-12 nodejs/reliability#663

Open

19 tasks

UlisesGascon added a commit that referenced this pull request

Sep 12, 2023


          2023-09-13, Version 20.7.0 (Current)

9f950df

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592

github-actions Bot mentioned this pull request

Sep 13, 2023

CI Reliability 2023-09-13 nodejs/reliability#664

Open

14 tasks

UlisesGascon added a commit that referenced this pull request

Sep 13, 2023


          2023-09-18, Version 20.7.0 (Current)

d9e2456

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592

UlisesGascon added a commit that referenced this pull request

Sep 16, 2023


          2023-09-18, Version 20.7.0 (Current)

3557c43

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592

UlisesGascon added a commit that referenced this pull request

Sep 18, 2023


          2023-09-18, Version 20.7.0 (Current)

a71037e

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
deps:
  * upgrade npm to 10.1.0 (npm team) #49570
  * upgrade npm to 10.0.0 (npm team) #49423
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592

UlisesGascon added a commit to UlisesGascon/node that referenced this pull request

Sep 18, 2023


          2023-09-18, Version 20.7.0 (Current)

b651e37

Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341
deps:
  * upgrade npm to 10.1.0 (npm team) nodejs#49570
  * upgrade npm to 10.0.0 (npm team) nodejs#49423
doc:
  * move and rename loaders section (Geoffrey Booth) nodejs#49261
  * add release key for Ulises Gascon (Ulises Gascón) nodejs#49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs#46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) nodejs#49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) nodejs#49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs#48975

PR-URL: nodejs#49592

coderabbitai Bot mentioned this pull request

Aug 3, 2026

Stage 3: dev seed script with paste-able session cookies guarzo/authGD#20

Merged

Reviewers

tniessen

tniessen left review comments

GeoffreyBooth

GeoffreyBooth approved these changes

atlowChemi

atlowChemi approved these changes

+1 more reviewer

kibertoad

kibertoad left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

notable-change

PRs with changes that should be highlighted in changelogs.

review wanted

PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

anonrig commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 7, 2023

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 10, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anonrig commented Sep 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.