GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: fix webstream pipe-to by rluvaton · Pull Request #49552 · nodejs/node

Conversation

@rluvaton

@rluvaton rluvaton commented Sep 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rluvaton
benchmark: fix webstream pipe-to
1c610ee
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Sep 8, 2023
rluvaton
rluvaton commented Sep 8, 2023
View reviewed changes
Comment thread benchmark/webstreams/pipe-to.js
highWaterMark: highWaterMarkR,
pull: function(controller) {
if (i++ === n) {
if (i++ < n) {

@rluvaton rluvaton Sep 8, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this does not call enqueue as it closes the stream immediately

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rluvaton rluvaton added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 8, 2023
@github-actions

github-actions Bot commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @rluvaton. Please 👍 to approve.
ronag and atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag approved these changes Sep 8, 2023
View reviewed changes
@rluvaton rluvaton added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 8, 2023
atlowChemi
atlowChemi approved these changes Sep 8, 2023
View reviewed changes
@rluvaton rluvaton mentioned this pull request Sep 8, 2023
stream: replace queue and readRequests with buffer list for performance improvement #49554
Closed
@rluvaton rluvaton added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7bf29b5 into nodejs:main Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7bf29b5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
rluvaton deleted the fix-webstream-pipe-benchmark branch September 8, 2023 12:57
@rluvaton rluvaton mentioned this pull request Sep 9, 2023
benchmark: shorten pipe-to by reducing number of chunks #49577
Merged
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@rluvaton @ruyadorno
benchmark: fix webstream pipe-to
4126a6e 
PR-URL: #49552
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronag ronag ronag approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rluvaton @nodejs-github-bot @ronag @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.